Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove falsy tests which don't align with interface specification #11

Closed
blake-regalia opened this issue Jan 11, 2019 · 2 comments
Closed

Comments

@blake-regalia
Copy link
Contributor

The interface specification clearly documents that it expects, w.r.t. the other argument, a Term for Term#equals(Term other) and a Quad for Quad#equal(Quad other). The behavior for unexpected types is not defined, i.e., whether it should return false or throw an Error: #132 and #133.

Until these issues are resolved, the falsy tests in this suite should not make assumptions about undefined behavior. Let's get this suite aligned with the specification for now and table such tests until we can come to a decision about the interface.

@RubenVerborgh
Copy link
Contributor

We should probably just move faster with rdfjs/data-model-spec#132 and rdfjs/data-model-spec#133

@bergos
Copy link
Contributor

bergos commented Jul 24, 2019

Obsoleted by spec update

@bergos bergos closed this as completed Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants