Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial react-tv setup throws and error with react-tv-navigation #9

Open
metoikos opened this issue Jun 8, 2018 · 4 comments
Open

Comments

@metoikos
Copy link

metoikos commented Jun 8, 2018

Hi all. First of all, thank you for your great effort to create an ecosystem around smart tv's.

I've just set up my development environment as instructed and started dev server with yarn start command and navigated to http://localhost:8080 with chrome browser. On the page, I had this error in console;

Uncaught Error: Argument appears to not be a ReactComponent. Keys: tag,key,type,stateNode,return,child,sibling,index,ref,pendingProps,memoizedProps,updateQueue,memoizedState,mode,effectTag,nextEffect,firstEffect,lastEffect,expirationTime,alternate,_debugID,_debugSource,_debugOwner,_debugIsCurrentlyTiming

Complete output here: http://dpaste.com/3EHE8C5

It's default boilerplate code of the react-tv-cli nothing added.

So I just removed withFocusable HOC and tried to render with standard component and everything just worked.
I couldn't quite figure out what is the problem here. Couple days ago I tried react-tv-navigation with react-dom (just replaced ReactTV.findDOMNode with ReactDOM.findDOMNode) to test if it is capable of achieving my needs on tv app and it just worked that time.

So, what could cause this, any idea?

@raphamorim
Copy link
Collaborator

Thank you @metoikos for the report!

Yeah, I know what is 😢
I need to update the way to work with refs on react-tv-navigation to the newest React-TV renderer.

@raphamorim
Copy link
Collaborator

@celiolatorraca can you take a look?

@parisaabasian
Copy link

I have the same problem, @raphamorim
Did you figure it out?what should I do? :(

@raphamorim
Copy link
Collaborator

yeah @parisaabasian, please re-install react-tv-cli@latest. Just fixed it to React versions <=16.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants