Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Library For Reconnecting Websocket #1041

Closed
rmorshea opened this issue Jun 12, 2023 · 5 comments
Closed

Use Library For Reconnecting Websocket #1041

rmorshea opened this issue Jun 12, 2023 · 5 comments
Assignees
@rmorshea
Labels
priority-2-moderate Should be resolved on a reasonable timeline. release-patch Warrents a patch release type-javascript Related to client-side code

Comments

@rmorshea
Copy link
Collaborator

Current Situation

Currently we implement our own reconnecting webscoket which is deficient in one way I do know, and probably others I'm unaware of. The one I know, is that we don't stop trying to reconnect after the connection is closed due to an error. Keeping track of how to respond in the case of each error code isn't something we should have to deal with. We should just use a library.

Proposed Actions

Use https://github.com/pladaria/reconnecting-websocket
@rmorshea rmorshea added flag-triage Not prioritized. priority-2-moderate Should be resolved on a reasonable timeline. type-javascript Related to client-side code release-patch Warrents a patch release and removed flag-triage Not prioritized. labels Jun 12, 2023
@Archmonger Archmonger changed the title Use Library For Reconnecting Webscoket Use Library For Reconnecting Websocket Jun 14, 2023
@Archmonger
Copy link
Contributor

Related issue: #525

@rmorshea
Copy link
Collaborator Author

Related: #1098 (reply in thread)

@rmorshea
Copy link
Collaborator Author

I think I'm going to try deploying on GCP and will prioritize this if I think this will make it possible/easier to do so. A lot of people seem to be trying out ReactPy that way.

@rmorshea rmorshea self-assigned this Jul 15, 2023
@rmorshea rmorshea added this to the 1.0.3 milestone Jul 15, 2023
@Archmonger
Copy link
Contributor

Archmonger commented Feb 23, 2024 •
edited
Loading

I ended up developing a robust reconnecting websocket within ReactPy-Django that can be ported over to ReactPy core identically.

The websocket can be configured within Python via settings.

@Archmonger Archmonger removed this from the 1.0.3 milestone Jan 25, 2025
@Archmonger
Copy link
Contributor

Closed in favor of #1113

@Archmonger Archmonger closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmorshea rmorshea

Labels
priority-2-moderate Should be resolved on a reasonable timeline. release-patch Warrents a patch release type-javascript Related to client-side code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmorshea @Archmonger