Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix starlette example for 'running reactpy' docs #1229

Closed
dridk opened this issue Sep 11, 2024 · 0 comments · Fixed by #1255
Closed

Fix starlette example for 'running reactpy' docs #1229

dridk opened this issue Sep 11, 2024 · 0 comments · Fixed by #1255
Labels
flag-triage Not prioritized.

Comments

@dridk
Copy link

dridk commented Sep 11, 2024

Current Situation

From here : https://reactpy.dev/docs/guides/getting-started/running-reactpy.html
Code example doesn't work . Backend import are missing.

from reactpy import component, html
from reactpy.backend.starlette import configure

# ==> missing : import Starlete

@component
def HelloWorld():
    return html.h1("Hello, world!")


app = Starlette()
configure(app, HelloWorld)

Proposed Actions

Try do fix it myself. But the doc example from the repository seems ok.

@dridk dridk added the flag-triage Not prioritized. label Sep 11, 2024
@dridk dridk changed the title Update doc for 'unning-reactpy' page Update doc for 'running-reactpy' page Sep 11, 2024
Archmonger added a commit to Archmonger/reactpy that referenced this issue Jan 26, 2025
@Archmonger Archmonger changed the title Update doc for 'running-reactpy' page Fix starlette example for 'running reactpy' docs Jan 26, 2025
@Archmonger Archmonger linked a pull request Jan 26, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag-triage Not prioritized.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant