From 3e18799685a963b441d63903b788cbb6f7e9289e Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 4 Feb 2024 12:15:10 -0700 Subject: [PATCH 01/21] fix sdist --- src/py/reactpy/.gitignore | 1 + src/py/reactpy/pyproject.toml | 56 +++++++---------------- src/py/reactpy/reactpy/backend/_common.py | 2 +- tasks.py | 8 +++- 4 files changed, 25 insertions(+), 42 deletions(-) diff --git a/src/py/reactpy/.gitignore b/src/py/reactpy/.gitignore index 0499d7590..b4362ae8c 100644 --- a/src/py/reactpy/.gitignore +++ b/src/py/reactpy/.gitignore @@ -2,3 +2,4 @@ # --- Build Artifacts --- reactpy/_static +js diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index 309248507..ed2ac2789 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -12,9 +12,7 @@ readme = "README.md" requires-python = ">=3.9" license = "MIT" keywords = ["react", "javascript", "reactpy", "component"] -authors = [ - { name = "Ryan Morshead", email = "ryan.morshead@gmail.com" }, -] +authors = [{ name = "Ryan Morshead", email = "ryan.morshead@gmail.com" }] classifiers = [ "Development Status :: 4 - Beta", "Programming Language :: Python", @@ -39,10 +37,7 @@ dependencies = [ [project.optional-dependencies] all = ["reactpy[starlette,sanic,fastapi,flask,tornado,testing]"] -starlette = [ - "starlette >=0.13.6", - "uvicorn[standard] >=0.19.0", -] +starlette = ["starlette >=0.13.6", "uvicorn[standard] >=0.19.0"] sanic = [ "sanic >=21", "sanic-cors", @@ -50,22 +45,10 @@ sanic = [ "setuptools", "uvicorn[standard] >=0.19.0", ] -fastapi = [ - "fastapi >=0.63.0", - "uvicorn[standard] >=0.19.0", -] -flask = [ - "flask", - "markupsafe>=1.1.1,<2.1", - "flask-cors", - "flask-sock", -] -tornado = [ - "tornado", -] -testing = [ - "playwright", -] +fastapi = ["fastapi >=0.63.0", "uvicorn[standard] >=0.19.0"] +flask = ["flask", "markupsafe>=1.1.1,<2.1", "flask-cors", "flask-sock"] +tornado = ["tornado"] +testing = ["playwright"] [project.urls] Source = "https://github.com/reactive-python/reactpy" @@ -101,13 +84,10 @@ cov-report = [ # "- coverage combine", "coverage report", ] -cov = [ - "test-cov {args}", - "cov-report", -] +cov = ["test-cov {args}", "cov-report"] [tool.hatch.envs.default.env-vars] -REACTPY_DEBUG_MODE="1" +REACTPY_DEBUG_MODE = "1" [tool.hatch.envs.lint] features = ["all"] @@ -124,16 +104,16 @@ dependencies = [ types = "mypy --strict reactpy" all = ["types"] +[tool.hatch.build.targets.sdist] +artifacts = ["js"] + [[tool.hatch.build.hooks.build-scripts.scripts]] -work_dir = "../../js" out_dir = "reactpy/_static" commands = [ - "npm ci", - "npm run build" -] -artifacts = [ - "app/dist/" + "if [ ! -d js ]; then ln -s ../../js js; fi", + "cd js && npm ci && npm run build; echo 'done'", ] +artifacts = ["js/app/dist/"] # --- Pytest --------------------------------------------------------------------------- @@ -159,9 +139,7 @@ warn_unused_ignores = true source_pkgs = ["reactpy"] branch = false parallel = false -omit = [ - "reactpy/__init__.py", -] +omit = ["reactpy/__init__.py"] [tool.coverage.report] fail_under = 100 @@ -174,6 +152,4 @@ exclude_lines = [ "if __name__ == .__main__.:", "if TYPE_CHECKING:", ] -omit = [ - "reactpy/__main__.py", -] +omit = ["reactpy/__main__.py"] diff --git a/src/py/reactpy/reactpy/backend/_common.py b/src/py/reactpy/reactpy/backend/_common.py index b4d6af19c..77c9a7ae0 100644 --- a/src/py/reactpy/reactpy/backend/_common.py +++ b/src/py/reactpy/reactpy/backend/_common.py @@ -21,7 +21,7 @@ MODULES_PATH = PATH_PREFIX / "modules" ASSETS_PATH = PATH_PREFIX / "assets" STREAM_PATH = PATH_PREFIX / "stream" -CLIENT_BUILD_DIR = Path(_reactpy_file_path).parent / "_static" / "app" / "dist" +CLIENT_BUILD_DIR = Path(_reactpy_file_path).parent / "_static" / "js" / "app" / "dist" async def serve_with_uvicorn( diff --git a/tasks.py b/tasks.py index e11d291e3..7816ce902 100644 --- a/tasks.py +++ b/tasks.py @@ -416,8 +416,14 @@ def prepare_py_release( def publish(dry_run: bool): with context.cd(package.path): + context.run("twine check dist/*") + + # check sdist install + context.run("pip install ./dist/*.tar.gz") + # check wheel install + context.run("pip install ./dist/*.whl") + if dry_run: - context.run("twine check dist/*") return context.run( From 6a92c01eb67e4a635bcedf9a3b508ee767c47f4e Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sat, 10 Feb 2024 11:50:22 -0700 Subject: [PATCH 02/21] use bash shell --- .github/workflows/.hatch-run.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/.hatch-run.yml b/.github/workflows/.hatch-run.yml index 1b21e4202..10533cc55 100644 --- a/.github/workflows/.hatch-run.yml +++ b/.github/workflows/.hatch-run.yml @@ -57,3 +57,4 @@ jobs: PYPI_USERNAME: ${{ secrets.pypi-username }} PYPI_PASSWORD: ${{ secrets.pypi-password }} run: hatch run ${{ inputs.hatch-run }} + shell: bash From b3b5cf63a33a0baec6517f7749912d0b8905598a Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 12:48:47 -0700 Subject: [PATCH 03/21] use python to make script cross-platform --- js | 1 + src/py/reactpy/pyproject.toml | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 120000 js diff --git a/js b/js new file mode 120000 index 000000000..46961779b --- /dev/null +++ b/js @@ -0,0 +1 @@ +../../js \ No newline at end of file diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index ed2ac2789..cdcd5f56f 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -110,7 +110,8 @@ artifacts = ["js"] [[tool.hatch.build.hooks.build-scripts.scripts]] out_dir = "reactpy/_static" commands = [ - "if [ ! -d js ]; then ln -s ../../js js; fi", + # link the js directory using python (e.g. if [ ! -d js ]; then ln -s ../../js js; fi) + "python -c \"import pathlib as p;js=p.Path('js');js.exists() or js.symlink_to(p.Path('..','..','js'),target_is_directory=True);\"", "cd js && npm ci && npm run build; echo 'done'", ] artifacts = ["js/app/dist/"] From 8eb17645767535987978a6b542cd137eb1b40c9e Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 12:50:34 -0700 Subject: [PATCH 04/21] remove js symlink --- js | 1 - 1 file changed, 1 deletion(-) delete mode 120000 js diff --git a/js b/js deleted file mode 120000 index 46961779b..000000000 --- a/js +++ /dev/null @@ -1 +0,0 @@ -../../js \ No newline at end of file From a9e72c4be8216dbbf63f8b40fbb6ce9ef6494440 Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 12:51:22 -0700 Subject: [PATCH 05/21] fix comment --- src/py/reactpy/pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index cdcd5f56f..0ebca2c7e 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -110,7 +110,7 @@ artifacts = ["js"] [[tool.hatch.build.hooks.build-scripts.scripts]] out_dir = "reactpy/_static" commands = [ - # link the js directory using python (e.g. if [ ! -d js ]; then ln -s ../../js js; fi) + # link the js directory if it doesn't exist - use Python to avoid platform differences "python -c \"import pathlib as p;js=p.Path('js');js.exists() or js.symlink_to(p.Path('..','..','js'),target_is_directory=True);\"", "cd js && npm ci && npm run build; echo 'done'", ] From 9325d362b1d0bcbd580a7d3aff1dd566aae5ac4c Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 12:56:57 -0700 Subject: [PATCH 06/21] remove shell bash --- .github/workflows/.hatch-run.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/.hatch-run.yml b/.github/workflows/.hatch-run.yml index 10533cc55..1b21e4202 100644 --- a/.github/workflows/.hatch-run.yml +++ b/.github/workflows/.hatch-run.yml @@ -57,4 +57,3 @@ jobs: PYPI_USERNAME: ${{ secrets.pypi-username }} PYPI_PASSWORD: ${{ secrets.pypi-password }} run: hatch run ${{ inputs.hatch-run }} - shell: bash From d64e122522d32eb23b97b548343feb8c8c7474f1 Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 14:37:15 -0700 Subject: [PATCH 07/21] echo dir contents --- src/py/reactpy/pyproject.toml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index 0ebca2c7e..cdabdd583 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -112,6 +112,8 @@ out_dir = "reactpy/_static" commands = [ # link the js directory if it doesn't exist - use Python to avoid platform differences "python -c \"import pathlib as p;js=p.Path('js');js.exists() or js.symlink_to(p.Path('..','..','js'),target_is_directory=True);\"", + # echo contents of the ./js directory + "ls -l js", "cd js && npm ci && npm run build; echo 'done'", ] artifacts = ["js/app/dist/"] From d416357c55652bcd8f55f355ab8640c3b497c3dd Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 14:41:54 -0700 Subject: [PATCH 08/21] echo on failing script line --- src/py/reactpy/pyproject.toml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index cdabdd583..00a7f5691 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -112,9 +112,7 @@ out_dir = "reactpy/_static" commands = [ # link the js directory if it doesn't exist - use Python to avoid platform differences "python -c \"import pathlib as p;js=p.Path('js');js.exists() or js.symlink_to(p.Path('..','..','js'),target_is_directory=True);\"", - # echo contents of the ./js directory - "ls -l js", - "cd js && npm ci && npm run build; echo 'done'", + "ls -l js && cd js && npm ci && npm run build; echo 'done'", ] artifacts = ["js/app/dist/"] From ce876747c502eb26cb0f6fdb9aa064caeefd7489 Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 14:51:39 -0700 Subject: [PATCH 09/21] try resolve first --- src/py/reactpy/pyproject.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index 00a7f5691..f5fe62b5c 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -111,8 +111,8 @@ artifacts = ["js"] out_dir = "reactpy/_static" commands = [ # link the js directory if it doesn't exist - use Python to avoid platform differences - "python -c \"import pathlib as p;js=p.Path('js');js.exists() or js.symlink_to(p.Path('..','..','js'),target_is_directory=True);\"", - "ls -l js && cd js && npm ci && npm run build; echo 'done'", + "python -c \"import pathlib as p;js=p.Path('js');js.exists() or js.symlink_to(p.Path('..','..','js').resolve(),target_is_directory=True);\"", + "cd js && npm ci && npm run build; echo 'done'", ] artifacts = ["js/app/dist/"] From 9176ddab3930198086145b082952dc70eecae74d Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 14:54:53 -0700 Subject: [PATCH 10/21] no need to check existance --- src/py/reactpy/pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index f5fe62b5c..8f4e381a6 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -111,7 +111,7 @@ artifacts = ["js"] out_dir = "reactpy/_static" commands = [ # link the js directory if it doesn't exist - use Python to avoid platform differences - "python -c \"import pathlib as p;js=p.Path('js');js.exists() or js.symlink_to(p.Path('..','..','js').resolve(),target_is_directory=True);\"", + "python -c \"import pathlib as p;js=p.Path('js');js.symlink_to(p.Path('..','..','js').resolve(),target_is_directory=True);\"", "cd js && npm ci && npm run build; echo 'done'", ] artifacts = ["js/app/dist/"] From 6e80020aefe31979b9de8b2cb23d9255c973261b Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 15:00:22 -0700 Subject: [PATCH 11/21] more readable python script --- src/py/reactpy/pyproject.toml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index 8f4e381a6..2ad2c74d3 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -111,7 +111,11 @@ artifacts = ["js"] out_dir = "reactpy/_static" commands = [ # link the js directory if it doesn't exist - use Python to avoid platform differences - "python -c \"import pathlib as p;js=p.Path('js');js.symlink_to(p.Path('..','..','js').resolve(),target_is_directory=True);\"", + """python -c \" + from pathlib import Path + js = Path('js') + js.symlink_to(Path('..','..','js').resolve(),target_is_directory=True) + \"""", "cd js && npm ci && npm run build; echo 'done'", ] artifacts = ["js/app/dist/"] From 9e128b61d51d008f04c43eef3cb17021e32f058d Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 15:02:57 -0700 Subject: [PATCH 12/21] fix script --- src/py/reactpy/pyproject.toml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index 2ad2c74d3..f5fe62b5c 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -111,11 +111,7 @@ artifacts = ["js"] out_dir = "reactpy/_static" commands = [ # link the js directory if it doesn't exist - use Python to avoid platform differences - """python -c \" - from pathlib import Path - js = Path('js') - js.symlink_to(Path('..','..','js').resolve(),target_is_directory=True) - \"""", + "python -c \"import pathlib as p;js=p.Path('js');js.exists() or js.symlink_to(p.Path('..','..','js').resolve(),target_is_directory=True);\"", "cd js && npm ci && npm run build; echo 'done'", ] artifacts = ["js/app/dist/"] From 5a5829dcab8cf233708d6e16316a85896453da6e Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 15:06:11 -0700 Subject: [PATCH 13/21] no echo done --- src/py/reactpy/pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index f5fe62b5c..ef7e7e5e7 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -112,7 +112,7 @@ out_dir = "reactpy/_static" commands = [ # link the js directory if it doesn't exist - use Python to avoid platform differences "python -c \"import pathlib as p;js=p.Path('js');js.exists() or js.symlink_to(p.Path('..','..','js').resolve(),target_is_directory=True);\"", - "cd js && npm ci && npm run build; echo 'done'", + "cd js && npm ci && npm run build", ] artifacts = ["js/app/dist/"] From 6c7fd8cf11c4a678f069b87d43a8a01eef40cc1a Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 15:22:54 -0700 Subject: [PATCH 14/21] preserve symlinks? --- src/js/app/vite.config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/js/app/vite.config.js b/src/js/app/vite.config.js index c97fb6dac..64a015757 100644 --- a/src/js/app/vite.config.js +++ b/src/js/app/vite.config.js @@ -7,6 +7,7 @@ export default defineConfig({ react: "preact/compat", "react-dom": "preact/compat", }, + preserveSymlinks: true, }, base: "/_reactpy/", }); From 3327f4e041bea908d3a382d72b786b6106236ca7 Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 15:52:51 -0700 Subject: [PATCH 15/21] always delete symlink --- src/py/reactpy/pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index ef7e7e5e7..6dbd66055 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -111,7 +111,7 @@ artifacts = ["js"] out_dir = "reactpy/_static" commands = [ # link the js directory if it doesn't exist - use Python to avoid platform differences - "python -c \"import pathlib as p;js=p.Path('js');js.exists() or js.symlink_to(p.Path('..','..','js').resolve(),target_is_directory=True);\"", + "python -c \"import pathlib as p;js = p.Path('js');js.unlink(missing_ok=True);js.symlink_to(p.Path('..', '..', 'js'), target_is_directory=True);\"", "cd js && npm ci && npm run build", ] artifacts = ["js/app/dist/"] From 954b09bb5945b71716eb69f88c8acaaebb4356ec Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 16:01:07 -0700 Subject: [PATCH 16/21] try unlinking again --- src/py/reactpy/pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index 6dbd66055..2e21ea53b 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -111,7 +111,7 @@ artifacts = ["js"] out_dir = "reactpy/_static" commands = [ # link the js directory if it doesn't exist - use Python to avoid platform differences - "python -c \"import pathlib as p;js = p.Path('js');js.unlink(missing_ok=True);js.symlink_to(p.Path('..', '..', 'js'), target_is_directory=True);\"", + "python -c \"import pathlib as p;js=p.Path('js');js.unlink(missing_ok=True);js.symlink_to(p.Path('..','..','js').resolve(),target_is_directory=True);\"", "cd js && npm ci && npm run build", ] artifacts = ["js/app/dist/"] From 3c0c35ae8e694345ccd71811a99357a73d5ba29e Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Sun, 11 Feb 2024 16:06:59 -0700 Subject: [PATCH 17/21] no resolve --- src/py/reactpy/pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index 2e21ea53b..533616da8 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -111,7 +111,7 @@ artifacts = ["js"] out_dir = "reactpy/_static" commands = [ # link the js directory if it doesn't exist - use Python to avoid platform differences - "python -c \"import pathlib as p;js=p.Path('js');js.unlink(missing_ok=True);js.symlink_to(p.Path('..','..','js').resolve(),target_is_directory=True);\"", + "python -c \"import pathlib as p;js=p.Path('js');js.unlink(missing_ok=True);js.symlink_to(p.Path('..','..','js'),target_is_directory=True);\"", "cd js && npm ci && npm run build", ] artifacts = ["js/app/dist/"] From 70cf1b7568a462fb29e5bf1fc2c16a50388c108f Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Wed, 30 Oct 2024 11:19:48 -0700 Subject: [PATCH 18/21] Re-add resolve --- src/py/reactpy/pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index f93ddb776..9914d18d3 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -110,7 +110,7 @@ artifacts = ["js"] out_dir = "reactpy/_static" commands = [ # link the js directory if it doesn't exist - use Python to avoid platform differences - "python -c \"import pathlib as p;js=p.Path('js');js.unlink(missing_ok=True);js.symlink_to(p.Path('..','..','js'),target_is_directory=True);\"", + "python -c \"import pathlib as p;js=p.Path('js');js.unlink(missing_ok=True);js.symlink_to(p.Path('..','..','js').resolve(),target_is_directory=True);\"", "cd js && npm ci && npm run build", ] artifacts = ["js/app/dist/"] From 8f20c28887ca6cfdee36d11c75b5377d561894f8 Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Wed, 30 Oct 2024 17:05:03 -0700 Subject: [PATCH 19/21] Fix artifacts --- src/py/reactpy/pyproject.toml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/py/reactpy/pyproject.toml b/src/py/reactpy/pyproject.toml index 9914d18d3..05d35c8e1 100644 --- a/src/py/reactpy/pyproject.toml +++ b/src/py/reactpy/pyproject.toml @@ -104,7 +104,10 @@ types = "mypy --strict reactpy" all = ["types"] [tool.hatch.build.targets.sdist] -artifacts = ["js"] +artifacts = ["_static"] + +[tool.hatch.build.targets.wheel] +artifacts = ["_static"] [[tool.hatch.build.hooks.build-scripts.scripts]] out_dir = "reactpy/_static" From 54e7ec5f0a72a657d62dd2d16141ce508b72d6cd Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Wed, 30 Oct 2024 17:06:03 -0700 Subject: [PATCH 20/21] Remove useless installs --- tasks.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tasks.py b/tasks.py index 7816ce902..5669025a4 100644 --- a/tasks.py +++ b/tasks.py @@ -418,11 +418,6 @@ def publish(dry_run: bool): with context.cd(package.path): context.run("twine check dist/*") - # check sdist install - context.run("pip install ./dist/*.tar.gz") - # check wheel install - context.run("pip install ./dist/*.whl") - if dry_run: return From ebdc2186d14a6f13e9183e85211c1a9f9769591b Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Wed, 30 Oct 2024 17:23:28 -0700 Subject: [PATCH 21/21] Add changelog --- docs/source/about/changelog.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/source/about/changelog.rst b/docs/source/about/changelog.rst index 325481f9a..8768c5160 100644 --- a/docs/source/about/changelog.rst +++ b/docs/source/about/changelog.rst @@ -25,6 +25,7 @@ Unreleased - :pull:`1200` - Fixed ``UnicodeDecodeError`` when using ``reactpy.web.export`` - :pull:`1224` - Fixes needless unmounting of JavaScript components during each ReactPy render. - :pull:`1126` - Fixed missing ``event["target"]["checked"]`` on checkbox inputs +- :pull:`1191` - Fixed missing static files on `sdist` Python distribution **Added**