New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Commands names violates documented convention #482

Open

LeiYangGH opened this issue Dec 7, 2021 · 0 comments

Labels

bug

LeiYangGH commented Dec 7, 2021

Describe the bug
The doc Command Names says:

Don't suffix ReactiveCommand properties' names with Command; instead, name the property using a verb that describes the command's action. For example:

public ReactiveCommand Synchronize { get; private set; }

But the sample code can find violations everywhere, just name a few:

CalculateCommand
https://github.com/reactiveui/ReactiveUI.Samples/blob/main/wpf/ReactiveUI.Samples.Basics/ViewModels/CalculatorViewModel.cs

StartAsyncCommand
https://github.com/reactiveui/ReactiveUI.Samples/blob/main/wpf/ReactiveUI.Samples.Commands/RxUI/MainVIewModel.cs

The text was updated successfully, but these errors were encountered:

LeiYangGH added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment