Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return FutureMono compatible for Netty5 #2560

Open
violetagg opened this issue Nov 2, 2022 · 1 comment
Open

Return FutureMono compatible for Netty5 #2560

violetagg opened this issue Nov 2, 2022 · 1 comment
Labels
type/enhancement A general enhancement
Milestone
2.0.x Backlog

Comments

@violetagg
Copy link
Member

violetagg commented Nov 2, 2022 •
edited
Loading

This PR #2250 needs to be reverted and FutureMono to be adapted for Netty5 API
@violetagg violetagg added the type/enhancement A general enhancement label Nov 2, 2022
@violetagg violetagg added this to the 2.0.x Backlog milestone Nov 2, 2022
@violetagg violetagg mentioned this issue Nov 2, 2022
Closed
violetagg added a commit that referenced this issue Nov 3, 2022
@violetagg
Use FutureMono instead of Mono#fromCompletionStage (#2565)
1aca50f 
Reactor Netty does not need the type of cancellation
provided by `Mono#fromCompletionStage`

Related to #2560
@violetagg
Copy link
Member Author

We need to address the TODO around removing listener

@violetagg violetagg mentioned this issue Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
2.0.x Backlog
Development

No branches or pull requests
1 participant
@violetagg