Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable addons entirely by URL pattern #472

Open
bollwyvl opened this issue Dec 15, 2024 · 0 comments
Open

Disable addons entirely by URL pattern #472

bollwyvl opened this issue Dec 15, 2024 · 0 comments
Labels
Needed: design decision A core team decision is required

Comments

@bollwyvl
Copy link

bollwyvl commented Dec 15, 2024

First off: really love the new features enabled by these addons for the general case. Thanks!

proposal

Add the ability for a site administrator to specify some regex/glob/gitignore patterns for which no extra scripts would be injected, at all, ever, on any version, to avoid any current or future problems.

motivation

On JupyterLite (and other sites that use it), inside highly interactive demos, the default hot key bindings are rather invasive. This leaves us having to disable some addons (especially docdiff and its claiming of d) for the whole site. Further, things like the version flyout visually overlap with other things shown in that region.

design ideas

As a quick mockup, this could be a textarea under the Advanced tab.

image

While not as slick as some dynamic form, this would make it easy to document how to copy and paste a known list of patterns.

alternatives

Some of these could be fixed, probably, by sniffing for event.currentTarget.contenteditable. But as a runtime-injected library, it's hard to reason about these things, as we'll never be able to anticipate which version will be served.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

2 participants