From d6f1a038016f8ca4cfd91875453ad154d97558eb Mon Sep 17 00:00:00 2001 From: Andrew Meyer Date: Tue, 30 Jan 2024 16:09:21 +0100 Subject: [PATCH] Try a different strategy --- .github/workflows/pr-realm-js.yml | 36 ++++++++++++++++--------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/.github/workflows/pr-realm-js.yml b/.github/workflows/pr-realm-js.yml index 9fceb108ce..bb6148fda0 100644 --- a/.github/workflows/pr-realm-js.yml +++ b/.github/workflows/pr-realm-js.yml @@ -39,6 +39,10 @@ jobs: run: npm ci --ignore-scripts - name: Bundle all packages run: npm run bundle + - name: Generate JSI + if: ${{ (matrix.variant.os == 'ios') && (matrix.variant.os == 'android') }} + run: | + npm run bindgen:generate:jsi --workspace realm # Due to a limitation in upload-artifact a redundant file is needed to force # preserving paths (https://github.com/actions/upload-artifact/issues/174) - name: Upload dist artifacts @@ -48,6 +52,7 @@ jobs: path: | README.md packages/*/dist + packages/realm/binding/jsi/jsi_init.cpp build: name: Build for ${{ matrix.variant.os }} ${{ matrix.variant.arch }} @@ -187,11 +192,6 @@ jobs: if: ${{ (matrix.variant.os != 'ios') && (matrix.variant.os != 'android') }} run: npm run build:node:prebuild:${{matrix.variant.arch}} --workspace realm - - name: Generate JSI - if: ${{ (matrix.variant.os == 'ios') && (matrix.variant.os == 'android') }} - run: | - npm run bindgen:generate:jsi --workspace realm - # build the c++ library for Android - name: Build Android if: ${{ (matrix.variant.os == 'android') }} @@ -199,13 +199,13 @@ jobs: # Due to a limitation in upload-artifact a redundant file is needed to force # preserving paths (https://github.com/actions/upload-artifact/issues/174) - - name: Upload prebuild artifact - uses: actions/upload-artifact@v3 - with: - name: realm-js-prebuilds - path: | - README.md - ${{ matrix.variant.artifact-path }} + # - name: Upload prebuild artifact + # uses: actions/upload-artifact@v3 + # with: + # name: realm-js-prebuilds + # path: | + # README.md + # ${{ matrix.variant.artifact-path }} integration-tests: name: Test ${{ matrix.variant.environment }} on ${{ matrix.variant.os }} (${{matrix.variant.target}}) @@ -311,10 +311,10 @@ jobs: with: name: realm-js-bundles - - name: Download prebuilds - uses: actions/download-artifact@v3 - with: - name: realm-js-prebuilds + # - name: Download prebuilds + # uses: actions/download-artifact@v3 + # with: + # name: realm-js-prebuilds - name: Install dependencies run: npm ci @@ -356,7 +356,9 @@ jobs: env: MOCHA_REMOTE_CONTEXT: ${{ steps.mocha-env.outputs.context }} timeout-minutes: 75 - run: npm run ${{ matrix.variant.target}} --prefix integration-tests/environments/${{ matrix.variant.environment }} + working-directory: ./integration-tests/environments/react-native + #run: npm run ${{ matrix.variant.target}} --prefix integration-tests/environments/${{ matrix.variant.environment }} + run: npx react-native run-ios --no-packager - name: Setup Java Gradle cache for android test app if: ${{ (matrix.variant.os == 'android') }}