Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit our workaround for flushing the microtask queue after calls from C++ into JS #6768

Closed
kraenhansen opened this issue Jun 28, 2024 · 1 comment · Fixed by #6791
Closed

Comments

@kraenhansen
Copy link
Member

About two years ago we merged a few PRs (#4725, #4579 and #4389) working around this issue in React Native: facebook/react-native#33006.

About 4 months ago a PR landed in React Native hinting that this might have been solved by enabling the Hermes microtask queue when bridgeless is enabled: facebook/react-native#43396. My initial (limited) investigation wasn't able to confirm this though (see my comments on the PR).

Our current workaround triggers this warning in React Native's BridgelessReactContext:

BridgelessReactContext: [WARNING] Bridgeless doesn't support CatalystInstance. Accessing an API that's not part of the new architecture is not encouraged usage.

I see a few ways forward:

  1. Trigger a flush of the microtask queue in another way, likely through JSI's drainMicrotasks
  2. Create a minimal reproduction for React Native to reproduce and fix the underlying issue.
Copy link

sync-by-unito bot commented Jun 28, 2024

➤ PM Bot commented:

Jira ticket: RJS-2852

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant