From 42cb7bb8b2b5ead0774afc7ca9f059c375bc6af2 Mon Sep 17 00:00:00 2001 From: "Zheng, Lei" Date: Mon, 8 Jun 2020 14:12:06 +0800 Subject: [PATCH] Gui: remove duplicated PropertyModel signal of dataChanged() --- src/Gui/propertyeditor/PropertyModel.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/Gui/propertyeditor/PropertyModel.cpp b/src/Gui/propertyeditor/PropertyModel.cpp index f93426121f053..e5b428a6b70d7 100644 --- a/src/Gui/propertyeditor/PropertyModel.cpp +++ b/src/Gui/propertyeditor/PropertyModel.cpp @@ -354,7 +354,12 @@ void PropertyModel::buildUp(const PropertyModel::PropertyList& props) auto flushChanges = [&]() { if (beginChange < 0) return; - dataChanged(this->index(beginChange,0,midx), this->index(endChange,1,midx)); + (void)endChange; + // There is no need to signal dataChange(), because PropertyEditor + // will call PropertyModel::updateProperty() on any property + // changes. + // + // dataChanged(this->index(beginChange,0,midx), this->index(endChange,1,midx)); beginChange = -1; };