Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-848: [release-4.18]: csiaddonsNode: Recreate CSIAddonsNode with active sidecar(s) #261

Merged

Conversation

black-dragon74
Copy link
Member

This patch adds a watcher to csi-addons sidecar which is responsible for re-creating CSIAddonNode(s) in case they are deleted manually.

Signed-off-by: Niraj Yadav [email protected]
(cherry picked from commit b46e722)

This patch adds a watcher to csi-addons sidecar which is
responsible for re-creating CSIAddonNode(s) in case they
are deleted manually.

Signed-off-by: Niraj Yadav <[email protected]>
(cherry picked from commit b46e722)
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Feb 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2025

@black-dragon74: This pull request references [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

This patch adds a watcher to csi-addons sidecar which is responsible for re-creating CSIAddonNode(s) in case they are deleted manually.

Signed-off-by: Niraj Yadav [email protected]
(cherry picked from commit b46e722)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@black-dragon74
Copy link
Member Author

The code spell error is unrelated to the changes of this PR.

@agarwal-mudit
Copy link
Member

/approve

@agarwal-mudit
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, black-dragon74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@black-dragon74
Copy link
Member Author

black-dragon74 commented Feb 18, 2025

/hold

Need to merge and backport rook and csi operator changes first.

@nixpanic
Copy link
Member

/hold

Need to merge and backport rook and csi operator changes first.

Got links to the DFBUGS or GitHub PRs that this depends on?

@black-dragon74
Copy link
Member Author

black-dragon74 commented Feb 18, 2025

/hold
Need to merge and backport rook and csi operator changes first.

Got links to the DFBUGS or GitHub PRs that this depends on?

Ceph CSI Operator PR is merged
Waiting on rook's upstream PR, back port here

@Madhu-1
Copy link
Member

Madhu-1 commented Feb 18, 2025

red-hat-storage/rook#830 Rook downstream PR for 4.18 branch

@black-dragon74
Copy link
Member Author

/hold cancel

All required PRs are merged. Namely, red-hat-storage/ceph-csi-operator#82 and red-hat-storage/rook#829

@Madhu-1
Copy link
Member

Madhu-1 commented Feb 19, 2025

/overide codespell

@Madhu-1
Copy link
Member

Madhu-1 commented Feb 19, 2025

@black-dragon74 CI is failing can you please take care of it(not related to this PR). @agarwal-mudit @nixpanic can we merge the PR manually?

@Madhu-1
Copy link
Member

Madhu-1 commented Feb 19, 2025

/override Codespell/codespell

Copy link

openshift-ci bot commented Feb 19, 2025

@Madhu-1: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Codespell/codespell

Only the following failed contexts/checkruns were expected:

  • codespell
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override Codespell/codespell

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Madhu-1
Copy link
Member

Madhu-1 commented Feb 19, 2025

/override "Codespell / codespell"

Copy link

openshift-ci bot commented Feb 19, 2025

@Madhu-1: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Codespell / codespell

Only the following failed contexts/checkruns were expected:

  • codespell
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Codespell / codespell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Madhu-1
Copy link
Member

Madhu-1 commented Feb 19, 2025

/override codespell

Copy link

openshift-ci bot commented Feb 19, 2025

@Madhu-1: Overrode contexts on behalf of Madhu-1: codespell

In response to this:

/override codespell

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 05edc9e into red-hat-storage:release-4.18 Feb 19, 2025
12 of 13 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2025

@black-dragon74: [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848) is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

This patch adds a watcher to csi-addons sidecar which is responsible for re-creating CSIAddonNode(s) in case they are deleted manually.

Signed-off-by: Niraj Yadav [email protected]
(cherry picked from commit b46e722)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants