-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFBUGS-848: [release-4.18]: csiaddonsNode: Recreate CSIAddonsNode with active sidecar(s) #261
DFBUGS-848: [release-4.18]: csiaddonsNode: Recreate CSIAddonsNode with active sidecar(s) #261
Conversation
This patch adds a watcher to csi-addons sidecar which is responsible for re-creating CSIAddonNode(s) in case they are deleted manually. Signed-off-by: Niraj Yadav <[email protected]> (cherry picked from commit b46e722)
@black-dragon74: This pull request references [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848), which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The code spell error is unrelated to the changes of this PR. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agarwal-mudit, black-dragon74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Need to merge and backport rook and csi operator changes first. |
Got links to the DFBUGS or GitHub PRs that this depends on? |
red-hat-storage/rook#830 Rook downstream PR for 4.18 branch |
/hold cancel All required PRs are merged. Namely, red-hat-storage/ceph-csi-operator#82 and red-hat-storage/rook#829 |
/overide codespell |
@black-dragon74 CI is failing can you please take care of it(not related to this PR). @agarwal-mudit @nixpanic can we merge the PR manually? |
/override Codespell/codespell |
@Madhu-1: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "Codespell / codespell" |
@Madhu-1: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override codespell |
@Madhu-1: Overrode contexts on behalf of Madhu-1: codespell In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
05edc9e
into
red-hat-storage:release-4.18
@black-dragon74: [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848) is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This patch adds a watcher to csi-addons sidecar which is responsible for re-creating CSIAddonNode(s) in case they are deleted manually.
Signed-off-by: Niraj Yadav [email protected]
(cherry picked from commit b46e722)