-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFBUGS-848: [release-4.18] manifest: add list and watch capabilities to provisioners #829
DFBUGS-848: [release-4.18] manifest: add list and watch capabilities to provisioners #829
Conversation
This patch adds `list` and `watch` verbs to cephfs and rbd provisioner roles for CSIAddonNode objects. Signed-off-by: Niraj Yadav <[email protected]> (cherry picked from commit ece302f)
@black-dragon74: This pull request references [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@black-dragon74: This pull request references [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848), which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
#830 is duplicate of it, i didnt noticed this PR, we can merge either one and close the other one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: black-dragon74, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@black-dragon74: [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848): All pull requests linked via external trackers have merged: [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848) has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This patch adds list and watch verbs to cephfs and rbd provisioners that are required to recreate the csiaddosnode object when they are deleted under unwanted circumferences. This is required for csi-addos to work properly after csi-addons/kubernetes-csi-addons#765 is merged same changes are made in cephcsi operator as well ceph/ceph-csi-operator#204
Signed-off-by: Niraj Yadav [email protected]
(cherry picked from commit ece302f)