Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-848: [release-4.18] manifest: add list and watch capabilities to provisioners #829

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

black-dragon74
Copy link
Member

This patch adds list and watch verbs to cephfs and rbd provisioners that are required to recreate the csiaddosnode object when they are deleted under unwanted circumferences. This is required for csi-addos to work properly after csi-addons/kubernetes-csi-addons#765 is merged same changes are made in cephcsi operator as well ceph/ceph-csi-operator#204

Signed-off-by: Niraj Yadav [email protected]
(cherry picked from commit ece302f)

This patch adds `list` and `watch` verbs to cephfs and rbd
provisioner roles for CSIAddonNode objects.

Signed-off-by: Niraj Yadav <[email protected]>
(cherry picked from commit ece302f)
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Feb 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2025

@black-dragon74: This pull request references [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848), which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This patch adds list and watch verbs to cephfs and rbd provisioners that are required to recreate the csiaddosnode object when they are deleted under unwanted circumferences. This is required for csi-addos to work properly after csi-addons/kubernetes-csi-addons#765 is merged same changes are made in cephcsi operator as well ceph/ceph-csi-operator#204

Signed-off-by: Niraj Yadav [email protected]
(cherry picked from commit ece302f)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@black-dragon74
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Feb 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2025

@black-dragon74: This pull request references [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Madhu-1
Copy link
Member

Madhu-1 commented Feb 18, 2025

#830 is duplicate of it, i didnt noticed this PR, we can merge either one and close the other one.

Copy link

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: black-dragon74, travisn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travisn travisn merged commit 8515075 into red-hat-storage:release-4.18 Feb 18, 2025
45 of 51 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2025

@black-dragon74: [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848) has been moved to the MODIFIED state.

In response to this:

This patch adds list and watch verbs to cephfs and rbd provisioners that are required to recreate the csiaddosnode object when they are deleted under unwanted circumferences. This is required for csi-addos to work properly after csi-addons/kubernetes-csi-addons#765 is merged same changes are made in cephcsi operator as well ceph/ceph-csi-operator#204

Signed-off-by: Niraj Yadav [email protected]
(cherry picked from commit ece302f)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug jira/valid-reference lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants