Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call form.destroy() when remove forms/fields in CollectionField and ListField #61

Open
redgeoff opened this issue Oct 12, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@redgeoff
Copy link
Owner

redgeoff commented Oct 12, 2018

Also:

  1. Use https://stackoverflow.com/a/46644561/2831606 to remove listener in FirebaseStore
  2. In https://github.com/redgeoff/mson/blob/master/src/fields/collection-field.js#L273, remove just CollectionField's listener when changing store and in destroy() also remove this listener on newStore (if it exists)
@redgeoff redgeoff added the bug Something isn't working label Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant