Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move _* attributes to the top #42

Open
mmuehlfeldRH opened this issue Feb 12, 2024 · 2 comments
Open

Move _* attributes to the top #42

mmuehlfeldRH opened this issue Feb 12, 2024 · 2 comments
Assignees

Comments

@mmuehlfeldRH
Copy link
Collaborator

Some of the _* attributes are separated with a blank line from each other or appear later in the template. For consistency reasons, can we move them up so that they appear all at the beginning of the file (without blank lines)

image

@msuchane msuchane self-assigned this Feb 12, 2024
@msuchane
Copy link
Collaborator

I agree it would be prettier to move the attributes together. The reason why the mod docs attribute is placed further down is that it follows the attribute placement in the upstream template files:

https://github.com/redhat-documentation/modular-docs/tree/main/modular-docs-manual/files

I'll see if I can consolidate this without diverging from the templates too much.

@mmuehlfeldRH
Copy link
Collaborator Author

Then it should better be improved upstream, so that it won't come back after the next template refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants