Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rm -rf requirements.txt step with proper rpm macro #5

Open
6 tasks done
chkumar246 opened this issue Jul 12, 2017 · 3 comments
Open
6 tasks done

Replace rm -rf requirements.txt step with proper rpm macro #5

chkumar246 opened this issue Jul 12, 2017 · 3 comments
Assignees

Comments

@chkumar246
Copy link
Contributor

chkumar246 commented Jul 12, 2017

In RDO packaging, we use rm -rf requirements.txt/test-requirements.txt in order to
avoid python package installation from pip during rpm package building process.
Since from Pike release, we have to replace this step with rpm macro %py_req_cleanup.

How to reproduce:

  1. Clone openstack-nova spec file git clone https://github.com/rdo-packages/nova-distgit
  2. Go to nova-distgit and open openstack-nova.spec in editor.
  3. You can find rm -rf {test-,}requirements.txt tools/{pip,test}-requires under %prep section
    in spec file.

How to fix:

  1. Replace ** rm -rf {test-,}requirements.txt tools/{pip,test}-requires ** with %py_req_cleanup
  2. Add BuildRequires: openstack-macros just below description section of main package.
  3. Add the changes file, commit it and send a Gerrit review.

Below is the list of packages which need same fixes:

Mentor: chandankumar
Note: Pick one of the package and comment in the comment box with review link.

@OGtrilliams
Copy link

Trying to update cinder, but not sure if I did it right: https://review.rdoproject.org/r/#/c/7637/

@OGtrilliams
Copy link

Did glance, too https://review.rdoproject.org/r/#/c/7685/

rdoproject pushed a commit to rdo-packages/cinder-distgit that referenced this issue Jul 14, 2017
As per issue redhat-openstack/easyfix#5

Change-Id: Iaa6c6db352aa5d154ede2a9cac642f965a8ef031
rdoproject pushed a commit to rdo-packages/nova-distgit that referenced this issue Jul 20, 2017
As per issue redhat-openstack/easyfix#5

Change-Id: I739689daa64854ff55046cf686c404c56d3d5a1b
rdoproject pushed a commit to rdo-packages/glance-distgit that referenced this issue Jul 24, 2017
As per issue redhat-openstack/easyfix#5

Change-Id: I744f4f01cf6da15fec37c8b4f3e3c902e20dcfdc
rdoproject pushed a commit to rdo-packages/keystone-distgit that referenced this issue Aug 7, 2017
As per issue redhat-openstack/easyfix#5

Change-Id: I027020c92d7aebd560f0de808f05f4c350681aad
rdoproject pushed a commit to rdo-packages/swift-distgit that referenced this issue Aug 7, 2017
As per issue redhat-openstack/easyfix#5

Change-Id: I6b8b0a46db2e44d959d5fdebedd3ce57cb1773df
rdoproject pushed a commit to rdo-packages/neutron-distgit that referenced this issue Aug 7, 2017
As per issue redhat-openstack/easyfix#5

Change-Id: Iead7810e60a54cf5c6c60b87be1bfae7ac73e6b0
@snecklifter snecklifter self-assigned this Aug 15, 2017
@snecklifter
Copy link
Contributor

Again, I'm sure there are more so a good grepping of spec files needs doing.

rdoproject pushed a commit to rdo-packages/novaclient-distgit that referenced this issue Sep 13, 2017
- change rm requirements to py_req_cleanup macro
- add BR openstack-macros
- move BR git to top level package

Change-Id: Ifeed886a3b66cf7edbf4314ca71b99f88e996850
Resolves: redhat-openstack/easyfix#5
rdoproject pushed a commit to rdo-packages/ceilometerclient-distgit that referenced this issue Sep 15, 2017
- convert to py_req_cleanup macro
- add openstack-macros BR

Change-Id: Ic8efbcae5dfc0edf6715f58f39e6f75204353f73
Resolves: redhat-openstack/easyfix#5
rdoproject pushed a commit to rdo-packages/cloudkitty-distgit that referenced this issue Sep 18, 2017
rdoproject pushed a commit to rdo-packages/ceilometer-distgit that referenced this issue Sep 18, 2017
rdoproject pushed a commit to rdo-packages/sahara-tests-distgit that referenced this issue Sep 18, 2017
rdoproject pushed a commit to rdo-packages/manila-distgit that referenced this issue Sep 18, 2017
rdoproject pushed a commit to rdo-packages/magnum-ui-distgit that referenced this issue Sep 19, 2017
rdoproject pushed a commit to rdo-packages/gnocchi-distgit that referenced this issue Sep 19, 2017
rdoproject pushed a commit to rdo-packages/manila-ui-distgit that referenced this issue Sep 19, 2017
rdoproject pushed a commit to rdo-packages/neutron-fwaas-distgit that referenced this issue Sep 19, 2017
rdoproject pushed a commit to rdo-packages/ironic-inspector-distgit that referenced this issue Sep 19, 2017
rdoproject pushed a commit to rdo-packages/ironic-ui-distgit that referenced this issue Sep 19, 2017
rdoproject pushed a commit to rdo-packages/ironic-python-agent-distgit that referenced this issue Sep 19, 2017
rdoproject pushed a commit to rdo-packages/panko-distgit that referenced this issue Sep 19, 2017
rdoproject pushed a commit to rdo-packages/vmware-nsx-distgit that referenced this issue Sep 19, 2017
rdoproject pushed a commit to rdo-packages/networking-vsphere-distgit that referenced this issue Sep 19, 2017
rdoproject pushed a commit to rdo-packages/networking-cisco-distgit that referenced this issue Sep 19, 2017
rdoproject pushed a commit to rdo-packages/trove-distgit that referenced this issue Sep 19, 2017
rdoproject pushed a commit to rdo-packages/proliantutils-distgit that referenced this issue Oct 24, 2017
rdoproject pushed a commit to rdo-packages/tempest-horizon-distgit that referenced this issue Oct 24, 2017
rdoproject pushed a commit to rdo-packages/congressclient-distgit that referenced this issue Oct 24, 2017
rdoproject pushed a commit to rdo-packages/mox3-distgit that referenced this issue Oct 24, 2017
rdoproject pushed a commit to rdo-packages/openstackclient-distgit that referenced this issue Oct 24, 2017
rdoproject pushed a commit to rdo-packages/vitrageclient-distgit that referenced this issue Oct 24, 2017
rdoproject pushed a commit to rdo-packages/debtcollector-distgit that referenced this issue Oct 24, 2017
rdoproject pushed a commit to rdo-packages/tacker-distgit that referenced this issue Nov 8, 2017
rdoproject pushed a commit to rdo-packages/neutron-lbaas-dashboard-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/troveclient-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/muranoclient-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/designateclient-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/oslo-utils-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/kuryr-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/keystonemiddleware-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/django_openstack_auth-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/oslo-db-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/mistral-lib-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/os-xenapi-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/oslo-i18n-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/oslo-context-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/swiftclient-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/paunch-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/os-faults-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/magnumclient-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/monascaclient-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/glanceclient-distgit that referenced this issue Nov 14, 2017
rdoproject pushed a commit to rdo-packages/neutron-lib-distgit that referenced this issue Nov 29, 2017
rdoproject pushed a commit to rdo-packages/oslo-db-distgit that referenced this issue Dec 13, 2017
redhat-openstack/easyfix#5

Missed adding BR to python2-* section

Fixed up issue created by I9d2fd0479dcf078346644947422e76cbbfcc3d1a

Change-Id: If07509f3060be724acf365c0681f91b0d81555e1
rdoproject pushed a commit to rdo-packages/networking-cisco-distgit that referenced this issue Sep 10, 2018
redhat-openstack/easyfix#5

Change-Id: Ia97f14569a977c9a0c7f1058d86dce7391a5d378
(cherry picked from commit ff6ea31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants