Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: Redis as a vector database quick start guide #1097

Closed
zostaw opened this issue Jan 26, 2025 · 5 comments · Fixed by redis/redis-py#3490
Closed

Feedback: Redis as a vector database quick start guide #1097

zostaw opened this issue Jan 26, 2025 · 5 comments · Fixed by redis/redis-py#3490
Assignees
Labels
bug Something isn't working dev

Comments

@zostaw
Copy link

zostaw commented Jan 26, 2025

Page https://redis.io/docs/latest/develop/get-started/vector-database

Hello, I'm not 100% sure if I'm missing something, but I think the doc has a mistake in python code snippet. It states:

from redis.commands.search.index_definition import IndexDefinition, IndexType

while index_definition doesn't exist, it throws:

ModuleNotFoundError: No module named 'redis.commands.search.index_definition'

I believe the proper command should be:

from redis.commands.search.indexDefinition import IndexDefinition, IndexType

That's what I've found in other examples and that's what worked for me.

I'm running it on Raspberry Pi, my python version is 3.11.2 and redis version 5.2.1

Cheers!

@dwdougherty dwdougherty self-assigned this Jan 27, 2025
@dwdougherty dwdougherty added bug Something isn't working dev labels Jan 27, 2025
@dwdougherty
Copy link
Collaborator

Thanks, @zostaw. I'll take a look.

@dwdougherty
Copy link
Collaborator

Hi @zostaw. Your assessment was correct. I've issued a PR to the redis-py repo that will correct this issue.

@zostaw
Copy link
Author

zostaw commented Feb 2, 2025

Thank you so much!

@dwdougherty
Copy link
Collaborator

Hi @zostaw. Closing the loop: my redis-py PR was merged, so the change should show up on redis.io/docs in the next day or two.

@uglide
Copy link
Contributor

uglide commented Feb 4, 2025

@dwdougherty we should pin the version of redis-py to the latest stable instead:

'dev_branch': '5.3'

PS: The name of the attribute is misleading :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants