Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Zero-width-space character creeping into terminal links, leading to 404 pages #11915

Open
1 task done
king8fisher opened this issue Jan 20, 2025 · 0 comments
Open
1 task done
Labels
bug/needs-info More information is needed for reproduction

Comments

@king8fisher
Copy link

What's not working?

terminal-link is still struggling with the old bug from 2022: sindresorhus/terminal-link#18
Some terminals, including Windows VSCode built-in are not recognized as supporting terminal links, as a result, a fallback version is printed instead with the link surrounded by ( ) and the link itself having invisible characters.

Similar issues/PRs:

Possible solutions:

How do we reproduce the bug?

Run a redwood upgrade script. For instance, after upgrading to Redwood 8.4.4, I'm getting the following link:

  • ❖ GitHub Release notes (​https://github.com/redwoodjs/redwood/releases%E2%80%8B) (those characters are actually invisible in the terminal)

Clicking the link to the releases page in the error message takes me to a 404 page due to the URL being malformed, containing a %E2%80%8B character in the end (standing for a zero-width space Unicode character).

What's your environment? (If it applies)

System:
    OS: Windows 11 10.0.22631
  Binaries:
    Node: 22.11.0 - ~\AppData\Local\Temp\xfs-7a25e855\node.CMD
    Yarn: 4.4.0 - ~\AppData\Local\Temp\xfs-7a25e855\yarn.CMD
  Browsers:
    Edge: Chromium (127.0.2651.74)
  npmPackages:
    @redwoodjs/cli-storybook-vite: 8.4.4 => 8.4.4 
    @redwoodjs/core: 8.4.4 => 8.4.4 
    @redwoodjs/project-config: 8.4.4 => 8.4.4 
  redwood.toml:
    [web]
      title = "Redwood App"
      port = 8983
      apiUrl = "/.redwood/functions" # You can customize graphql and dbauth urls individually too: see https://redwoodjs.com/docs/app-configuration-redwood-toml#api-paths
      includeEnvironmentVariables = [
        # Add any ENV vars that should be available to the web side to this array
        # See https://redwoodjs.com/docs/environment-variables#web
      ]
    [api]
      port = 8982
    [browser]
      open = true
    [notifications]
      versionUpdates = ["latest"]

Are you interested in working on this?

  • I'm interested in working on this
@king8fisher king8fisher added the bug/needs-info More information is needed for reproduction label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/needs-info More information is needed for reproduction
Projects
None yet
Development

No branches or pull requests

1 participant