Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any plans of adding more of the Ruby pact tools functionality to Pactman? #36

Open
MatthewMiele opened this issue Jan 17, 2019 · 2 comments
Labels
convince me Please convince me of the merit of this proposal

Comments

@MatthewMiele
Copy link

MatthewMiele commented Jan 17, 2019

There seems to be just two pieces of functionality left that is stopping us from removing the Ruby Pact tools dependency from our Python projects. They are

  • pact-broker publish to publish the Pacts themselves
  • pact-broker create-version-tag to tag existing Pacts that have already been published to the broker.

Do you have any plans to recreate these in Pactman or pure python equivalents.

@richard-reece
Copy link
Contributor

I'm not sure I need to duplicate the functionality of the pact-broker tool.

@richard-reece richard-reece added the convince me Please convince me of the merit of this proposal label Jan 17, 2019
@MatthewMiele
Copy link
Author

MatthewMiele commented Jan 18, 2019

I think I got too carried away with trying to replace all of our Pact logic with Pactman! Those two commands don't really need to be in Pactman (but it would still be cool) as they can be accomplished just with simple curl commands. So this would be enough to remove all of our Ruby dependency :)

  • Publish Pacts
curl -XPUT -H "Content-Type: application/json" [email protected] http://PACT_BROKER/pacts/provider/PROVIDER_NAME/consumer/CONSUMER_NAME/version/1.0.0
  • TAG Pacts already in the broker:
curl  -XPUT http://PACT_BROKER/pacticipants/PACTICIPANT/versions/1.0.0/tags/TAG_NAME -H "Content-Type: application/json"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
convince me Please convince me of the merit of this proposal
Projects
None yet
Development

No branches or pull requests

2 participants