Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

origin_station routes filtering doesn't work #13

Open
AdriDevelopsThings opened this issue Aug 3, 2022 · 0 comments
Open

origin_station routes filtering doesn't work #13

AdriDevelopsThings opened this issue Aug 3, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@AdriDevelopsThings
Copy link
Member

e.g:
look at the following train_vehicle response:

{"number":302,"name":"Hansestadt Lübeck","train_type":"ICE","building_series":403,"trips":[{"group_index":0,"vehicle_timestamp":"2022-08-01T20:03:20.000Z","trip_timestamp":"2022-08-01T12:00:54.000Z","initial_departure":"2022-08-02T05:55:00.000Z","train_type":"ICE","train_number":1006,"origin_station":"München Hbf","destination_station":"Berlin Hbf","stops":[{"cancelled":0,"station":"München Hbf","scheduled_departure":"2022-08-02T05:55:00.000Z","departure":"2022-08-02T05:55:00.000Z","scheduled_arrival":null,"arrival":null},{"cancelled":0,"station":"Nürnberg Hbf","scheduled_departure":"2022-08-02T07:02:00.000Z","departure":"2022-08-02T07:02:00.000Z","scheduled_arrival":"2022-08-02T06:58:00.000Z","arrival":"2022-08-02T06:58:00.000Z"},{"cancelled":0,"station":"Erfurt Hbf","scheduled_departure":"2022-08-02T08:11:00.000Z","departure":"2022-08-02T08:11:00.000Z","scheduled_arrival":"2022-08-02T08:09:00.000Z","arrival":"2022-08-02T08:09:00.000Z"},{"cancelled":0,"station":"Halle(Saale)Hbf","scheduled_departure":"2022-08-02T08:40:00.000Z","departure":"2022-08-02T08:40:00.000Z","scheduled_arrival":"2022-08-02T08:38:00.000Z","arrival":"2022-08-02T08:38:00.000Z"},{"cancelled":0,"station":"Berlin Südkreuz","scheduled_departure":"2022-08-02T09:46:00.000Z","departure":"2022-08-02T09:46:00.000Z","scheduled_arrival":"2022-08-02T09:44:00.000Z","arrival":"2022-08-02T09:44:00.000Z"},{"cancelled":0,"station":"Berlin Hbf (tief)","scheduled_departure":"2022-08-02T10:06:00.000Z","departure":"2022-08-02T10:06:00.000Z","scheduled_arrival":"2022-08-02T09:51:00.000Z","arrival":"2022-08-02T09:51:00.000Z"},{"cancelled":0,"station":"Berlin-Spandau","scheduled_departure":"2022-08-02T10:16:00.000Z","departure":"2022-08-02T10:16:00.000Z","scheduled_arrival":"2022-08-02T10:14:00.000Z","arrival":"2022-08-02T10:14:00.000Z"},{"cancelled":0,"station":"Hamburg-Altona","scheduled_departure":null,"departure":null,"scheduled_arrival":"2022-08-02T12:03:00.000Z","arrival":"2022-08-02T12:03:00.000Z"}]}]}

The destination_station is Berlin Hbf but the stop has the name Berlin Hbf (tief)so filtering is not available.
Berlin Hbf and Berlin Hbf (tief) are equal so the filtering algorithm needs a system to understand this equal stations.

@AdriDevelopsThings AdriDevelopsThings added the bug Something isn't working label Aug 3, 2022
@AdriDevelopsThings AdriDevelopsThings self-assigned this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant