-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update explanation on @daiji256/rehype-mathml
in plugins.md
#189
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 154 163 +9
=========================================
+ Hits 154 163 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about adding the scope name.
This list current goal is not to be a list of npm package names. It’s a list of plugin names.
Co-authored-by: Titus <[email protected]> Signed-off-by: Tatsunori Uchino <[email protected]>
I decided to list it without a scope, consistent with other libraries such as @mapbox/rehype-prism, @benjc/rehype-scroll-to-top, and @hbsnow/rehype-sectionize. |
I forgot to revert addition of the namespace. Thank you for your notification. |
If other than Squash and Merge is going to be applied here, I will squash these 3 commits in one in advance. Please tell me so before merging or rebasing. |
I always squash! :) Thank you! |
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
Thank you for merging. |
Initial checklist
Description of changes
The current explanation on
@daiji256/rehype-mathml
has the following problems:npm i