Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings from unit tests related to scoring #371

Open
elray1 opened this issue Jul 19, 2022 · 0 comments
Open

Warnings from unit tests related to scoring #371

elray1 opened this issue Jul 19, 2022 · 0 comments

Comments

@elray1
Copy link
Collaborator

elray1 commented Jul 19, 2022

When running unit tests, there are a lot of warnings coming from tests for scoring. Here's an example:

── Warning (test-score_forecasts.R:3323:3): interval coverage  is correct, 2 intervals, median and point, use_median_as_point FALSE ──
The following warnings were produced when checking inputs:
1.  Some forecasts have different numbers of rows (e.g. quantiles or samples). scoringutils found: 1, 5. This is not necessarily a problem, but make sure this is intended.
Backtrace:
  1. covidHubUtils::score_forecasts(...)
       at test-score_forecasts.R:3323:2
 13. scoringutils::score(data = joint_df_target)
 14. scoringutils::check_forecasts(data)

If these warnings are intended, we should check for that with expect_warning. If these warnings are not intended/necessary, we should update test cases to avoid them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant