Enable the "require PR before merge" branch protection + revise pkgdown workflow #412
Comments
bsweger
added a commit
that referenced
this issue
Jan 29, 2024
The prior PR had added docs/ to .gitignore for developer convenience, but that causes the pkgdown workflow to fail when it tries to commit documentation. We should address this as part of issue #412, so this is a temporary patch to fixup the CI pipeline
Merged
bsweger
added a commit
that referenced
this issue
Jan 29, 2024
The prior PR had added docs/ to .gitignore for developer convenience, but that causes the pkgdown workflow to fail when it tries to commit documentation. We should address this as part of issue #412, so this is a temporary patch to fixup the CI pipeline
bsweger
added a commit
that referenced
this issue
Jan 29, 2024
The prior PR had added docs/ to .gitignore for developer convenience, but that causes the pkgdown workflow to fail when it tries to commit documentation. We should address this as part of issue #412, so this is a temporary patch to fixup the CI pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the pkgdown workflow commits changes to the main branch when a PR is merged: https://github.com/reichlab/covidHubUtils/blob/master/.github/workflows/pkgdown.yaml#L33
This prevents us from enabling the "require a pull request before merging" branch protection.
There's likely a standard process we can adopt that doesn't require direct comments when merging (e.g., adding a commit to the PR when it's opened).
Definition of done:
The text was updated successfully, but these errors were encountered: