RSpec test suite hangs intermittently unless sync! has been called

[keithrbennett]

Environment

• SemanticLogger version: 4.11.0
• Ruby version 2.7.6
• OS versions: Mac OS 12.6, Centos 7
• No Rails or other web frameworks

Expected Behavior

The RSpec test suite completes successfully (whether there are failures or not).

Actual Behavior

After having replaced our older custom logging code with SemanticLogger, the RSpec test suite intermittently hangs at random places. We are using SemanticLogger version 4.11.0, and this occurs on both Mac OS 12.6 and Centos 7.

When we call sync! to eliminate the separate logging thread, the hanging disappears and the test suite finishes successfully.

I cannot say with any certainty that it is a SemanticLogger bug, but neither can I think of anything we're doing that would cause this.

Is there anything you can think of that would cause this behavior?

In case it matters, I am calling flush after each example:

    rspec_config.after(:each) do
      SemanticLogger.flush
    end

[keithrbennett]

@reidmorrison I suggest you use @eviljoel 's MR to resolve this. His solution works now, is simpler, and it's likely that most people won't care about the time it takes to wait for the thread to close. I'm not sure if he has updated it after your refactoring though.