Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics section of the docs is out of date #283

Closed
kranzky opened this issue Jun 19, 2024 · 1 comment
Closed

Metrics section of the docs is out of date #283

kranzky opened this issue Jun 19, 2024 · 1 comment

Comments

@kranzky
Copy link
Contributor

kranzky commented Jun 19, 2024

This was added in #35cb18c0 but the code was refactored in #e848e327. I'm guessing that the correct usage should now be:

subscriber = SemanticLogger::Metric::NewRelic.new

instead of:

subscriber = SemanticLogger::Metrics::NewRelic.new

This also means that https://logger.rocketjob.io/metrics.html is incorrect.

Environment

  • Ruby Version: 3.2.2
  • Semantic Logger Version: 4.15.0
  • Application/framework names and versions: Rails and Sidekiq
  • Rails Semantic Logger Version: 4.14.0

Rails Configuration

on_worker_boot do
  ActiveRecord::Base.establish_connection
  SemanticLogger.reopen
  SemanticLogger.on_log(SemanticLogger::Metrics::NewRelic.new)
end

Full Stack Trace

[51] WARNING hook before_worker_boot failed with exception (NameError) uninitialized constant SemanticLogger::Metrics

Expected Behavior

  • Metrics are sent to newrelic

Actual Behavior

  • Metrics are not sent to newrelic

Pull Request

#284

kranzky added a commit to kranzky/semantic_logger that referenced this issue Jun 19, 2024
Replace `SemanticLogger::Metrics` with `SemanticLogger::Metric`

Fixes issue reidmorrison#283
kranzky added a commit to kranzky/semantic_logger that referenced this issue Jun 19, 2024
Replace `SemanticLogger::Metrics` with `SemanticLogger::Metric`

Fixes issue reidmorrison#283
@reidmorrison
Copy link
Owner

Thank you for the pull request to fix the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants