Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(URGENT) Crash in fetching with ISBN due to missing 'place' #5

Closed
ronaldtse opened this issue Mar 5, 2025 · 3 comments
Closed

(URGENT) Crash in fetching with ISBN due to missing 'place' #5

ronaldtse opened this issue Mar 5, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link

$ bundle exec relaton version
CLI => 1.20.0
relaton => 1.20.0
relaton-bib => 1.20.5
relaton-iso-bib => 1.20.0
relaton-gb => 1.20.0
relaton-iec => 1.20.0
relaton-ietf => 1.20.0
relaton-iso => 1.20.0
relaton-itu => 1.20.1
relaton-nist => 1.20.0
relaton-ogc => 1.20.0
relaton-calconnect => 1.20.0
relaton-omg => 1.20.0
relaton-un => 1.20.1
relaton-w3c => 1.20.0
relaton-ieee => 1.20.0
relaton-iho => 1.20.0
relaton-bipm => 1.20.3
relaton-ecma => 1.20.0
relaton-cie => 1.20.0
relaton-bsi => 1.20.0
relaton-cen => 1.20.0
relaton-iana => 1.20.0
relaton-3gpp => 1.20.0
relaton-oasis => 1.20.0
relaton-doi => 1.20.0
relaton-jis => 1.20.0
relaton-xsf => 1.20.0
relaton-ccsds => 1.20.2
relaton-etsi => 1.20.0
relaton-isbn => 1.20.0
relaton/plateau => 1.20.0
$ relaton fetch 'isbn:9781107683167'
gems/relaton-bib-1.20.5/lib/relaton_bib/bibliographic_item.rb:266:in `initialize': undefined method `map' for nil (NoMethodError)

      @place          = args.fetch(:place, []).map do |pl|
                                              ^^^^
	from gems/relaton-isbn-1.20.0/lib/relaton_isbn/parser.rb:18:in `new'
	from gems/relaton-isbn-1.20.0/lib/relaton_isbn/parser.rb:18:in `parse'
	from gems/relaton-isbn-1.20.0/lib/relaton_isbn/parser.rb:13:in `parse'
	from gems/relaton-isbn-1.20.0/lib/relaton_isbn/open_library.rb:25:in `get'
	from gems/relaton-isbn-1.20.0/lib/relaton_isbn/processor.rb:20:in `get'
	from gems/relaton-1.20.0/lib/relaton/db.rb:193:in `fetch_doc'
	from gems/relaton-1.20.0/lib/relaton/db.rb:495:in `net_retry'
	from gems/relaton-1.20.0/lib/relaton/db.rb:448:in `fetch_entry'
	from gems/relaton-1.20.0/lib/relaton/db.rb:436:in `new_bib_entry'
	from gems/relaton-1.20.0/lib/relaton/db.rb:408:in `check_bibliocache'
	from gems/relaton-1.20.0/lib/relaton/db.rb:70:in `fetch'
	from gems/relaton-cli-1.20.0/lib/relaton/cli/command.rb:189:in `fetch_document'
	from gems/relaton-cli-1.20.0/lib/relaton/cli/command.rb:37:in `fetch'
	from gems/thor-1.3.2/lib/thor/command.rb:28:in `run'
	from gems/thor-hollaback-0.2.1/lib/thor/hollaback.rb:71:in `block in run'
	from gems/hollaback-0.1.1/lib/hollaback/sequence.rb:34:in `call'
	from gems/thor-hollaback-0.2.1/lib/thor/hollaback.rb:71:in `run'
	from gems/thor-1.3.2/lib/thor/invocation.rb:127:in `invoke_command'
	from gems/thor-1.3.2/lib/thor.rb:538:in `dispatch'
	from gems/thor-1.3.2/lib/thor/base.rb:584:in `start'
	from gems/relaton-cli-1.20.0/lib/relaton/cli.rb:60:in `start'
	from gems/relaton-cli-1.20.0/exe/relaton:20:in `<top (required)>'


$ relaton fetch 'isbn:9780861543212'
gems/relaton-bib-1.20.5/lib/relaton_bib/bibliographic_item.rb:266:in `initialize': undefined method `map' for nil (NoMethodError)

      @place          = args.fetch(:place, []).map do |pl|
                                              ^^^^
	from gems/relaton-isbn-1.20.0/lib/relaton_isbn/parser.rb:18:in `new'
	from gems/relaton-isbn-1.20.0/lib/relaton_isbn/parser.rb:18:in `parse'
	from gems/relaton-isbn-1.20.0/lib/relaton_isbn/parser.rb:13:in `parse'
	from gems/relaton-isbn-1.20.0/lib/relaton_isbn/open_library.rb:25:in `get'
	from gems/relaton-isbn-1.20.0/lib/relaton_isbn/processor.rb:20:in `get'
	from gems/relaton-1.20.0/lib/relaton/db.rb:193:in `fetch_doc'
	from gems/relaton-1.20.0/lib/relaton/db.rb:495:in `net_retry'
	from gems/relaton-1.20.0/lib/relaton/db.rb:448:in `fetch_entry'
	from gems/relaton-1.20.0/lib/relaton/db.rb:436:in `new_bib_entry'
	from gems/relaton-1.20.0/lib/relaton/db.rb:408:in `check_bibliocache'
	from gems/relaton-1.20.0/lib/relaton/db.rb:70:in `fetch'
	from gems/relaton-cli-1.20.0/lib/relaton/cli/command.rb:189:in `fetch_document'
	from gems/relaton-cli-1.20.0/lib/relaton/cli/command.rb:37:in `fetch'
	from gems/thor-1.3.2/lib/thor/command.rb:28:in `run'
	from gems/thor-hollaback-0.2.1/lib/thor/hollaback.rb:71:in `block in run'
	from gems/hollaback-0.1.1/lib/hollaback/sequence.rb:34:in `call'
	from gems/thor-hollaback-0.2.1/lib/thor/hollaback.rb:71:in `run'
	from gems/thor-1.3.2/lib/thor/invocation.rb:127:in `invoke_command'
	from gems/thor-1.3.2/lib/thor.rb:538:in `dispatch'
	from gems/thor-1.3.2/lib/thor/base.rb:584:in `start'
	from gems/relaton-cli-1.20.0/lib/relaton/cli.rb:60:in `start'
	from gems/relaton-cli-1.20.0/exe/relaton:20:in `<top (required)>'
@ronaldtse
Copy link
Author

This is blocking opengeospatial/Temporal-Abstract-Spec#107

@ronaldtse
Copy link
Author

Confirm works. Thanks!

@andrew2net
Copy link
Contributor

fixed in relaton-bib v 1.20.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants