Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Choosing Notify global dropdown gives blank screen when it does not match Type #449

Closed
BaccanoMob opened this issue Oct 4, 2024 · 1 comment · Fixed by #456
Closed
Labels
bug Something isn't working

Comments

@BaccanoMob
Copy link

I have a notify config for ntfy in the config.yml file (for example, say ntfy_global).

When I use the WebUI to create a service and then add notify, the notify form pops up. When I select ntfy_global in the dropdown, the screen goes blank.

Workaround: Choose the type drop down field first to ntfy then choose the global.

Solution: Choosing global should first modify the Type drop down field (possibly disable this field while at it) before setting the global settings.

@BaccanoMob BaccanoMob added the bug Something isn't working label Oct 4, 2024
@JosephKav JosephKav linked a pull request Oct 5, 2024 that will close this issue
@JosephKav
Copy link
Collaborator

Thanks for reporting this :).
Took a look and it seemed to be where it checks whether the .actions are for a different notify type. But if the currently selected type didn't have a .actions, it would try and loop over undefined and get a TypeError. Fixed this by just defaulting that var to an empty list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants