Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables missing align="center" support #68

Closed
4 tasks done
dsernst opened this issue Aug 6, 2024 · 3 comments
Closed
4 tasks done

Tables missing align="center" support #68

dsernst opened this issue Aug 6, 2024 · 3 comments
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on

Comments

@dsernst
Copy link

dsernst commented Aug 6, 2024

Initial checklist

Affected packages and versions

remark-gfm 4.0.0

Link to runnable example

No response

Steps to reproduce

| Tables   |      Are      |  Cool |
|----------|:-------------:|------:|
| col 1 is |  left-aligned | $1600 |
| col 2 is |    centered   |   $12 |
| col 3 is | right-aligned |    $1 |

(from example in bottom right corner of https://www.tablesgenerator.com/markdown_tables)

Expected behavior

Demo'ing left, center, and right alignment:

Tables Are Cool
col 1 is left-aligned $1600
col 2 is centered $12
col 3 is right-aligned $1

Actual behavior

Everything left aligned:

Tables Are Cool
col 1 is left-aligned $1600
col 2 is centered $12
col 3 is right-aligned $1
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 6, 2024
@ChristianMurphy
Copy link
Member

Welcome @dsernst! 👋
It is supported, you can see an example of it working here.

https://stackblitz.com/edit/github-xvqrna?file=src%2Fmain.ts

You are either not using remark-gfm or may have a version or configuration issue.
Please update all your remark related dependencies to latest.
If the issue persists, please share a runnable reproduction so others can assist.

@ChristianMurphy ChristianMurphy closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2024
@ChristianMurphy ChristianMurphy added the 🤷 no/invalid This cannot be acted upon label Aug 6, 2024

This comment has been minimized.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Aug 6, 2024
@dsernst
Copy link
Author

dsernst commented Aug 6, 2024

Ok, thanks for the quick reply and working example.

I now see there is a param.style.textAlign: center being passed down for the component to use.

You were right! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

2 participants