From 8f38118e44298d609224c6074ae6519d385196f1 Mon Sep 17 00:00:00 2001 From: Rishi Viswanathan <128200692+risv1@users.noreply.github.com> Date: Thu, 29 Aug 2024 20:10:29 +0530 Subject: [PATCH 1/5] [docs] Fix Typo in createSessionStorage (#9919) --- contributors.yml | 1 + docs/utils/sessions.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/contributors.yml b/contributors.yml index ed10edd92ff..cb553aee01d 100644 --- a/contributors.yml +++ b/contributors.yml @@ -546,6 +546,7 @@ - remix-run-bot - richardhunghhw - riencoertjens +- risv1 - rkulinski - rlfarman - roachjc diff --git a/docs/utils/sessions.md b/docs/utils/sessions.md index 240a8617a91..647289fd31b 100644 --- a/docs/utils/sessions.md +++ b/docs/utils/sessions.md @@ -218,7 +218,7 @@ Remix makes it easy to store sessions in your own database if needed. The `creat - `createData` will be called from `commitSession` on the initial session creation when no session ID exists in the cookie - `readData` will be called from `getSession` when a session ID exists in the cookie - `updateData` will be called from `commitSession` when a session ID already exists in the cookie -- `deleteData` is called from `destorySession` +- `deleteData` is called from `destroySession` The following example shows how you could do this using a generic database client: From 4f1d0fff8c75cf04e676ec590bee6426bd227c86 Mon Sep 17 00:00:00 2001 From: nauvalazhar Date: Tue, 3 Sep 2024 21:40:18 +0700 Subject: [PATCH 2/5] docs: replace 'clientside' with 'client side' (#9936) Co-authored-by: Matt Brophy --- contributors.yml | 1 + docs/start/tutorial.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/contributors.yml b/contributors.yml index cb553aee01d..79b015bc084 100644 --- a/contributors.yml +++ b/contributors.yml @@ -483,6 +483,7 @@ - mustak - n8agrin - na2hiro +- nauvalazhar - nareshbhatia - naveed-fida - navid-kalaei diff --git a/docs/start/tutorial.md b/docs/start/tutorial.md index 418cdac49d1..625f94d1e65 100644 --- a/docs/start/tutorial.md +++ b/docs/start/tutorial.md @@ -785,7 +785,7 @@ export const action = async ({ Without client side routing, if a server redirected after a `POST` request, the new page would fetch the latest data and render. As we learned before, Remix emulates this model and automatically revalidates the data on the page after the `action` call. That's why the sidebar automatically updates when we save the form. The extra revalidation code doesn't exist without client side routing, so it doesn't need to exist with client side routing in Remix either! -One last thing. Without JavaScript, the [`redirect`][redirect] would be a normal redirect. However, with JavaScript it's a clientside redirect, so the user doesn't lose client state like scroll positions or component state. +One last thing. Without JavaScript, the [`redirect`][redirect] would be a normal redirect. However, with JavaScript it's a client-side redirect, so the user doesn't lose client state like scroll positions or component state. ## Redirecting new records to the edit page From 5dc3b67dc31f3df7b1b0298ae4e9cac9c5ae1c06 Mon Sep 17 00:00:00 2001 From: Remix Run Bot Date: Tue, 3 Sep 2024 14:41:35 +0000 Subject: [PATCH 3/5] chore: format --- contributors.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributors.yml b/contributors.yml index 79b015bc084..9e79eea4757 100644 --- a/contributors.yml +++ b/contributors.yml @@ -483,8 +483,8 @@ - mustak - n8agrin - na2hiro -- nauvalazhar - nareshbhatia +- nauvalazhar - naveed-fida - navid-kalaei - nexxeln From 44f949c6add8a044a6f63a46a321d48440ac9629 Mon Sep 17 00:00:00 2001 From: klirium Date: Thu, 5 Sep 2024 17:06:47 +0300 Subject: [PATCH 4/5] [docs] fix layout in nested-layouts-without-nested-urls section (#9940) --- contributors.yml | 1 + docs/file-conventions/routes.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/contributors.yml b/contributors.yml index 9e79eea4757..43b732596e8 100644 --- a/contributors.yml +++ b/contributors.yml @@ -703,3 +703,4 @@ - zayenz - zhe - zwhitchcox +- klirium diff --git a/docs/file-conventions/routes.md b/docs/file-conventions/routes.md index e33004d18d5..4c01fed5c2a 100644 --- a/docs/file-conventions/routes.md +++ b/docs/file-conventions/routes.md @@ -246,7 +246,7 @@ Sometimes you want to share a layout with a group of routes without adding any p | `/` | `app/routes/_index.tsx` | `app/root.tsx` | | `/login` | `app/routes/_auth.login.tsx` | `app/routes/_auth.tsx` | | `/register` | `app/routes/_auth.register.tsx` | `app/routes/_auth.tsx` | -| `/concerts` | `app/routes/concerts.tsx` | `app/routes/concerts.tsx` | +| `/concerts` | `app/routes/concerts.tsx` | `app/root.tsx` | | `/concerts/salt-lake-city` | `app/routes/concerts.$city.tsx` | `app/routes/concerts.tsx` | Think of the `_leading` underscore as a blanket you're pulling over the filename, hiding the filename from the URL. From 7dece0e4db691fc9e5dfce27ad6373c46b6ef56c Mon Sep 17 00:00:00 2001 From: Remix Run Bot Date: Thu, 5 Sep 2024 14:08:17 +0000 Subject: [PATCH 5/5] chore: format --- contributors.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributors.yml b/contributors.yml index 43b732596e8..71848026652 100644 --- a/contributors.yml +++ b/contributors.yml @@ -366,6 +366,7 @@ - kishanhitk - kiyadotdev - klauspaiva +- klirium - knowler - konradkalemba - krolebord @@ -703,4 +704,3 @@ - zayenz - zhe - zwhitchcox -- klirium