converted CRLF ending lines to LF ones in api/src/structures/custom_responses.py #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2025 02:11
…esponses.py let ruff organise the imports
|
I'm reallly sorry, I'm quite new to github, and I just saw cherry picking was what I would have to do here, creating 2 branches each for one commit and then make 2 separate PR. Am I right? I'm really sorry for the mess I'm learning and you pay it! |
dw its fine lol. |
|
Ok, so should I make 2 separate prs or 1 for both commits (docker + new lines formatting)? BTW, thanks for accepting being my mentor 🤣 I'll PM you soon to see how we can match our schedules for practicing. I'm so glad, I though it would take months to find someone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble with custom_response.py (which I didn't touch) where windows style ending lines CRLF were making my IDE buggy, so I ended up converting it to Linux style LF.