-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split helm chart version and appVersion #54
Comments
Sounds fine to me |
I'm not sure it's worth it? We've had 1 pull request in the ~6 months this repo has existed. I think it would be easier to just document how to increment the version for chart related changes. |
@JamieMagee Ok, how do i need to change the chart version, without going out of sync with the renovate version? So we don't get a conflict on next renovate update. |
@viceice I think the version bump that you did was correct. You added a build version. This is ignored for comparisons, so chart-testing fails, the next increment of the version will include any fixes in the previous commit. These happen so often, so it's usually not a long wait. The current PR open, which bumps the major version to 23 should fix this, but there's a docs issue that slipped in via the previous PR. |
Can you fix that? I'm in an very early state working with helm charts |
Sure, I'll take a look tomorrow |
This still a thing? Seeing the issues the past few days, having the option to update outside of Renovate releases is perhaps desirable. |
@MindTooth sure, but we don't have a conclusion yet. So we maybe need to find more pros or cons. |
Hey, I'd vote for splitting the versions too. I would like to be able to follow semver for this chart and its components, not Renovate directly. |
What's the best way to deal with the If it's the last one, I should implement renovatebot/renovate#4728 😅 Also, what should we do with the existing releases? Do you want to start from scratch? Or just bump the major version? |
IMHO :
(edit: typos) |
Anybody know semantic-release like tool to get this mostly automatically done. like we do for renovate itself and our gitlab-runner templates. |
This comment was marked as outdated.
This comment was marked as outdated.
this would benefit: |
no, deprecated. |
@JamieMagee I would implement like we do for our gitlab templates. |
I'll implement semantic release the next days |
Are you going to bump the major version? Or can helm handle version epochs? |
I'll do a major bump. i like to make some major breaking change to simplify the chart. see dind removal issue. |
I think we should split the chart version from the renovate image version to more easily push chart updates.
We can then simply publish semver compliant versions.
Everybody can override the renovate version if required.
/cc @JamieMagee @rarkins
If you like or dislike this to be done please vote for this issue with 👍 of 👎 emoji
The text was updated successfully, but these errors were encountered: