Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split helm chart version and appVersion #54

Open
viceice opened this issue Aug 26, 2020 · 20 comments
Open

Split helm chart version and appVersion #54

viceice opened this issue Aug 26, 2020 · 20 comments
Assignees
Labels
breaking Breaking change, requires major version bump enhancement New feature or request

Comments

@viceice
Copy link
Member

viceice commented Aug 26, 2020

I think we should split the chart version from the renovate image version to more easily push chart updates.

We can then simply publish semver compliant versions.
Everybody can override the renovate version if required.

/cc @JamieMagee @rarkins


If you like or dislike this to be done please vote for this issue with 👍 of 👎 emoji

@viceice viceice added the enhancement New feature or request label Aug 26, 2020
@rarkins
Copy link
Contributor

rarkins commented Aug 26, 2020

Sounds fine to me

@JamieMagee
Copy link
Contributor

I'm not sure it's worth it? We've had 1 pull request in the ~6 months this repo has existed.

I think it would be easier to just document how to increment the version for chart related changes.

@viceice
Copy link
Member Author

viceice commented Aug 26, 2020

@JamieMagee Ok, how do i need to change the chart version, without going out of sync with the renovate version? So we don't get a conflict on next renovate update.

@JamieMagee
Copy link
Contributor

@viceice I think the version bump that you did was correct. You added a build version. This is ignored for comparisons, so chart-testing fails, the next increment of the version will include any fixes in the previous commit. These happen so often, so it's usually not a long wait.

The current PR open, which bumps the major version to 23 should fix this, but there's a docs issue that slipped in via the previous PR.

@viceice
Copy link
Member Author

viceice commented Aug 26, 2020

Can you fix that? I'm in an very early state working with helm charts

@JamieMagee
Copy link
Contributor

Sure, I'll take a look tomorrow

@MindTooth
Copy link
Contributor

This still a thing? Seeing the issues the past few days, having the option to update outside of Renovate releases is perhaps desirable.

@viceice
Copy link
Member Author

viceice commented Sep 24, 2020

@MindTooth sure, but we don't have a conclusion yet. So we maybe need to find more pros or cons.

@Djiit
Copy link
Contributor

Djiit commented Oct 2, 2020

Hey, I'd vote for splitting the versions too. I would like to be able to follow semver for this chart and its components, not Renovate directly.
Most of the time, I'll upgrade Renovate by changing the version in the values files.
If you want to continue to upgrade this chart whenever a new Renovate version comes out, you could release PATCH versions, bumping the default Renovate version.

@JamieMagee
Copy link
Contributor

What's the best way to deal with the image.tag value? Should it be unset by default, and you're required to pass in a version? Or should it be set to latest? Or should we try and roughly follow the semver of Renovate itself i.e. major versions of Renovate mean a new major version of the chart, and minor versions of Renovate still mean a minor version of the chart, but we maybe only bump the version on a weekly/monthly schedule?

If it's the last one, I should implement renovatebot/renovate#4728 😅

Also, what should we do with the existing releases? Do you want to start from scratch? Or just bump the major version?

@Djiit
Copy link
Contributor

Djiit commented Oct 2, 2020

IMHO :

  • continue to pin the image.tag; it should be considered as a sane default + a version that is known to be working with this chart.
  • Have a look at how GitLab handles their GitLab-runner's chart: https://gitlab.com/gitlab-org/charts/gitlab-runner/-/blob/master/CHANGELOG.md. I find it pretty sane; and I, as an admin, can choose to update things separately. It's not your last proposal, the one before (roughly follow the semver of Renovate itself).
  • You can just bump the major version. From a user PoV, nothing breaks between the current version and the "split" version.

(edit: typos)

@viceice
Copy link
Member Author

viceice commented Aug 3, 2021

Anybody know semantic-release like tool to get this mostly automatically done. like we do for renovate itself and our gitlab-runner templates.

https://gitlab.com/renovate-bot/renovate-runner

@mbrandau

This comment was marked as outdated.

@viceice
Copy link
Member Author

viceice commented May 16, 2023

this would benefit:

@viceice
Copy link
Member Author

viceice commented May 16, 2023

@viceice I think standard-version might work.

no, deprecated.

@viceice
Copy link
Member Author

viceice commented May 16, 2023

What's the best way to deal with the image.tag value? Should it be unset by default, and you're required to pass in a version? Or should it be set to latest? Or should we try and roughly follow the semver of Renovate itself i.e. major versions of Renovate mean a new major version of the chart, and minor versions of Renovate still mean a minor version of the chart, but we maybe only bump the version on a weekly/monthly schedule?

If it's the last one, I should implement renovatebot/renovate#4728 😅

Also, what should we do with the existing releases? Do you want to start from scratch? Or just bump the major version?

@JamieMagee I would implement like we do for our gitlab templates.

@viceice viceice self-assigned this May 16, 2023
@viceice
Copy link
Member Author

viceice commented May 16, 2023

I'll implement semantic release the next days

@viceice viceice pinned this issue May 16, 2023
@viceice viceice added the breaking Breaking change, requires major version bump label May 16, 2023
@JamieMagee
Copy link
Contributor

I'll implement semantic release the next days

Are you going to bump the major version? Or can helm handle version epochs?

@viceice
Copy link
Member Author

viceice commented May 16, 2023

I'll do a major bump. i like to make some major breaking change to simplify the chart. see dind removal issue.

@jon-rei

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, requires major version bump enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants