-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renovate spam GitHub issues #10902
Comments
Strange - must be a pattern which our sanitizers miss. Also strange that it's an open issue being referenced in a changelog. We need to locate the backlink in the PRs, then locate the raw changelog it's derived from, and then fix our sanitisation. |
@rarkins I assume it's because of this link in the changelog: https://github.com/mui-org/material-ui/blame/next/CHANGELOG.md#L16 |
@zharinov Could you take a look? |
Okay |
Please test in private repos so that we don't increase the back links any further. I know if you delete a link then the backlink still remains, although maybe if you delete the whole repo then it disappears. |
Yes, the whole repo deletion works, while link deletion isn't |
Maybe the "." at the end of that link fools the linkify we use? There just be something special about that link because the others seem fine and we haven't had a link spam complaint in at least a year |
Hi @oliviertassinari, did you notice another occurrences of this bug for other issues? We think it has something to do with markdown parsing of particular line you mentioned in the |
Not I can think of. Happy to hear that it's an isolated/edge-case issue. |
🎉 This issue has been resolved in version 25.69.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thanks for the fix |
We need to unfortunately reopen this due to a regression error causing mui/material-ui#11133 to be reverted |
🎉 This issue has been resolved in version 25.72.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
If using the hosted app, please skip to the next section.
Otherwise, if self-hosted, please complete the following:
Please select which platform you are using:
Renovate version: any
Describe the bug
Renovate opens pull requests linking the PRs on the changelog without any proxies. This makes the work of the maintainers harder. We can no longer easily find all the related effort to a given issue.
Have you created a minimal reproduction repository?
See https://github.com/mui-org/material-ui/issues/27170
The text was updated successfully, but these errors were encountered: