Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] All wallets tab is empty #3128

Open
vanyasav opened this issue Oct 19, 2024 · 6 comments
Open

[bug] All wallets tab is empty #3128

vanyasav opened this issue Oct 19, 2024 · 6 comments
Labels
bug Something isn't working needs review

Comments

@vanyasav
Copy link

Link to minimal reproducible example

https://github.com/vanyasav/angular-reown-wagmi/tree/all_wallets

Summary

Having setup config this way:

    this.modal = createAppKit({
      allWallets: 'SHOW',
      adapters: [wagmiAdapter],
      networks: [immutableZkEvmTestnet],
      metadata,
      projectId: PROJECT_ID,
      includeWalletIds: [
        'c57ca95b47569778a828d19178114f4db188b89b763c899ba0be274e97267d96',
      ],
    });

To fix this one must add a field featuredWalletIds with the same array as in includeWalletIds

image

List of related npm package versions

    "@reown/appkit": "^1.1.6",
    "@reown/appkit-adapter-wagmi": "^1.1.6",
@vanyasav vanyasav added bug Something isn't working needs review labels Oct 19, 2024
@dvlss
Copy link

dvlss commented Oct 22, 2024

I have the same problem

@zk118
Copy link

zk118 commented Oct 24, 2024

same here

@YadongChen
Copy link

YadongChen commented Oct 24, 2024

A tip, it may be related to the following issue:

#2961 (The number of wallets returned varies significantly across chains (e.g., 380+ for Ethereum mainnet, 60 for Base, 3 for Base Sepolia))

It seems that when the react/web SDK performs an all-wallets query, if a chain is specified, it may not be able to query all the wallets that are "theoretically" supported.

For less popular chains, you can only manually specify: featuredWalletIds to avoid all-wallet queries being empty

Related query requests:https://api.web3modal.org/getWallets?page=1&chains=eip155:【Chain ID 】


一个提示,可能与如下issue有关:

#2961 (同链返回的钱包数量差异很大(例如,以太坊主网为 380+,Base 为 60,Base Sepolia 为 3))

似乎react / web端的SDK,进行all-wallets查询时,如果指定了一个chain,则不一定能将“理论上”支持的钱包都查询出来。

对于比较“冷门”的chain,只能手动指定:featuredWalletIds来避免all-wallet查询是空

相关查询请求:https://api.web3modal.org/getWallets?page=1&chains=eip155:【Chain ID 】

@dvdbrv
Copy link

dvdbrv commented Nov 4, 2024

so the issue is still there, I'm experiencing this right now. The web3modal.org domain has expired and the api response is just Forbidden

@dvdbrv
Copy link

dvdbrv commented Nov 4, 2024

hopefully gets fixed soon, cause this is crippling everything

@vanyasav
Copy link
Author

@rtomas still an issue in 1.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs review
Projects
None yet
Development

No branches or pull requests

6 participants
@zk118 @vanyasav @YadongChen @dvlss @dvdbrv and others