Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE REQUEST: Add NachoSpigot support #307

Closed
zhusun890 opened this issue Apr 6, 2022 · 4 comments
Closed

FEATURE REQUEST: Add NachoSpigot support #307

zhusun890 opened this issue Apr 6, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@zhusun890
Copy link

Is your feature request related to a problem? Please describe.
When somebody joins a server with NachoSpigot and on pre-login state, it will be disconnected by reason "Exception Connecting: NativeIOException : readAddress(...) failed: Connection reset by peer"

Describe the solution you'd like
Add support for NachoSpigot

Describe alternatives you've considered to solve your solution without
us adding this as a feature?

A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@zhusun890 zhusun890 added the enhancement New feature or request label Apr 6, 2022
@amnoah
Copy link
Contributor

amnoah commented Apr 6, 2022

Solution: don't use Spigot forks that mess with random stuff in order to make minuscule optimizations.

(ofc Retrooper/DefineOutside decide on outcomes for this stuff)

@ghost
Copy link

ghost commented Apr 7, 2022

Not a PacketEvents issue. Issue tracked in CobbleSword/NachoSpigot#356.

@retrooper
Copy link
Owner

Tomorrow I will look into it, but something questionable is this works on any other server software.

@retrooper retrooper pinned this issue Apr 7, 2022
@retrooper
Copy link
Owner

NachoSpigot now works. We recently added a Paper injector, which is more efficient on Paper software and luckily works on Nacho. f9136db

@retrooper retrooper unpinned this issue Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants