You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is it an internal implementation limitation that causes this discrepancy? It does seem like a deliberate design decision in certain case - root level "ID" keys on API models are almost always _id instead of id (while any nested objects or sub-objects use id instead). However this bothers me for two reasons: General inconsistency, but also how Bonfire events are documented.
Take the EmojiCreate event:
The "Emoji" model contains an _id key, so I assume the event would have the field serialized this way when sent over the websocket.
However, you see the EmojiDelete event right below it, and now the same identifying field is serialized as id instead.
It would be nice to unify their naming in one way or another. I am fine with _id everywhere, but consistency is the goal of this request.
The text was updated successfully, but these errors were encountered:
What do you want to see?
Is it an internal implementation limitation that causes this discrepancy? It does seem like a deliberate design decision in certain case - root level "ID" keys on API models are almost always
_id
instead ofid
(while any nested objects or sub-objects useid
instead). However this bothers me for two reasons: General inconsistency, but also how Bonfire events are documented.Take the EmojiCreate event:
The "Emoji" model contains an
_id
key, so I assume the event would have the field serialized this way when sent over the websocket.However, you see the EmojiDelete event right below it, and now the same identifying field is serialized as
id
instead.It would be nice to unify their naming in one way or another. I am fine with
_id
everywhere, but consistency is the goal of this request.The text was updated successfully, but these errors were encountered: