Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to mark attachments as spoilers on upload #346

Open
insertish opened this issue Aug 6, 2021 · 3 comments
Open

feat: ability to mark attachments as spoilers on upload #346

insertish opened this issue Aug 6, 2021 · 3 comments
Labels
crate:services:autumn crates/services/autumn enhancement New feature or request

Comments

@insertish
Copy link
Member

No description provided.

@insertish insertish added the enhancement New feature or request label Aug 6, 2021
@Iikorni
Copy link

Iikorni commented Dec 7, 2021

I'm interested in seeing if I could tackle this - it seems deceptively simple, albeit I'd have some basic spitball-y questions about the approach. I might be overthinking this a bit, but I'm wondering what the best way to signal the client that the attachment should be "spoilered" might be. I know Discord seemingly uses the approach of literally just appending SPOILER_ to the name of the file and seemingly reacting to that, but that seems a bit clunky? Perhaps it's the best form of in-band signaling there is, but I feel like it misses the point a bit. Database wise, this shouldn't be much harder than adding a new field on the entity for files, but I'm just wondering where to go from there.

Sorry, this is a bit of a ramble - just looking to get your thoughts on it.

@MagnusHJensen
Copy link

Would a viable solution be to just prefix files that are marked as spoiler with SPOILER_ and then the frontend handles actually blurring the file?

@acceleratorlastorder
Copy link

S3 does support metadata; it could simply be metadata. But in my opinion the best approach would be to implement that in the database that handles the message/chat, not the file server, but that's just me rambling.

@insertish insertish transferred this issue from revoltchat/autumn Sep 29, 2024
@insertish insertish changed the title Ability to mark attachment as a spoiler. feat: ability to mark attachments as spoilers on upload Sep 29, 2024
@insertish insertish added the crate:services:autumn crates/services/autumn label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate:services:autumn crates/services/autumn enhancement New feature or request
Projects
Status: 🙋 Upvoting
Development

No branches or pull requests

4 participants