Unknown table/db references

[sean-gilliam]

There exists a couple of references to a table named gabe20010201051916.

https://github.com/rezalas/riftshadow/blob/main/code/devextra.c#L977

https://github.com/rezalas/riftshadow/blob/main/code/devextra.c#L1075-L1079

The table seems to have this schema

zposter - varchar(n)
zposter_email - varchar(n)
zsubject - varchar(n)
zmessage - varchar(n)
zdatetime - varchar(n)e
zaddress - varchar(n)
zunique - varchar(n)
zthreadid - varchar(n) 
zdelete - varchar(n)
zmod - varchar(n)

Looking through the code, it appears to be from the nonexistent riftforum database. Since we don't have the schema for that database, these sql calls will error out and cause additional overhead. Propose we delete these calls.

[sean-gilliam]

Also note that the following methods call the missing riftforum database and can be deleted as well.

MYSQL *open_fconn(void)

MYSQL_ROW one_fquery_row(char *query)

Those functions appear in the same file.

[Psypher9]

who was gabe? and what did they know?

We may never truly know

[rezalas]

Holy crap, you found the permadeath logger. It noted on the forum every time a character permanently died along with all of their stats, how they died, and such so people could read it. The log appears to generate a forum note to gabe for every death.

As for who gabe was, I'm not sure, but he may have been the dev that went on to work in the game industry full time after college. I can't be sure. But, I believe it's possible some of the devs that worked on it may still watch the repos from time to time. I know one joined our discord at one point and we chatted for a while about it.

[Psypher9]

So a permadeath logger sounds pretty sick honestly.

Is that something that just isn't supported right now because we don't have the forum?

[rezalas]

Also note that the following methods call the missing riftforum database and can be deleted as well.

MYSQL *open_fconn(void)

MYSQL_ROW one_fquery_row(char *query)

Those functions appear in the same file.

So, just so we can preserve the actions, would it make sense to migrate that code into a dedicated function then key it behind a config switch so we could enable/disable the functionality? It could make it easier in the future to regain the features should we ever decide to support a forum. Or, more likely, a website graveyard that pulls from SQL.

[Psypher9]

Oooooh, feature flags. I like that

[rezalas]

So a permadeath logger sounds pretty sick honestly.

Is that something that just isn't supported right now because we don't have the forum?

Sadly yes. In a lot of MMOs players had to self-report permadeath, but in RS it was automated for characters I believe over level 10.

[sean-gilliam]

Also note that the following methods call the missing riftforum database and can be deleted as well.
MYSQL *open_fconn(void)
MYSQL_ROW one_fquery_row(char *query)
Those functions appear in the same file.

So, just so we can preserve the actions, would it make sense to migrate that code into a dedicated function then key it behind a config switch so we could enable/disable the functionality? It could make it easier in the future to regain the features should we ever decide to support a forum. Or, more likely, a website graveyard that pulls from SQL.

We could totally do that.