From 473dca78c5c2f722e2f76c611870cea6f9b15d34 Mon Sep 17 00:00:00 2001
From: Rebeca Gallardo <rgallardo@netflix.com>
Date: Thu, 31 Aug 2023 14:21:33 -0700
Subject: [PATCH] Run tests on multiple JDKs

---
 .github/workflows/nebula-ci.yml | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/nebula-ci.yml b/.github/workflows/nebula-ci.yml
index 64ccd5e1..6b52181a 100644
--- a/.github/workflows/nebula-ci.yml
+++ b/.github/workflows/nebula-ci.yml
@@ -3,8 +3,6 @@ on:
   push:
     branches:
       - '*'
-    tags-ignore:
-      - '*'
   pull_request:
 
 jobs:
@@ -12,8 +10,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        # test against JDK 8
-        java: [ 8 ]
+        # test against JDK 8, 17 and 19. We should add 22 soon, too.
+        java: [ 8 17 19]
     name: CI with Java ${{ matrix.java }}
     steps:
       - uses: actions/checkout@v3
@@ -22,7 +20,10 @@ jobs:
       - name: Setup jdk
         uses: actions/setup-java@v3
         with:
-          java-version: ${{ matrix.java }}
+          # Install both the version we'll test with AND 8, which goes later so that it's the default for gradle to run with.
+          java-version: |
+            ${{ matrix.java }}
+            8
           distribution: 'zulu'
       - uses: actions/cache@v3
         id: gradle-cache
@@ -39,7 +40,7 @@ jobs:
           restore-keys: |
             - ${{ runner.os }}-gradlewrapper-
       - name: Build with Gradle
-        run: ./gradlew --info --stacktrace build
+        run: ./gradlew --info --stacktrace -PtestJdk=${{matrix.java}} build
         env:
           CI_NAME: github_actions
           CI_BUILD_NUMBER: ${{ github.sha }}