Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pretty printers for opium types #133

Closed
anuragsoni opened this issue Jan 3, 2020 · 1 comment
Closed

pretty printers for opium types #133

anuragsoni opened this issue Jan 3, 2020 · 1 comment

Comments

@anuragsoni
Copy link
Collaborator

In the current Cohttp implementation, we have sexp derivers for all the underlying http types via Cohttp. As part of #94 we tried to build and run using httpaf-lwt-unix. The sexp ppx was turned off for now as Httpaf doesn't define sexp derivers. It might be tedious but we should explore just defining our own derivers without using the ppx. One added benefit could be it'd make it easier to use the dune future_syntax shim so we can write the bind/map in direct style.

We should be able to depend on just sexplib0 for the sexp related things.
@anuragsoni
Copy link
Collaborator Author

This is now done in the current master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anuragsoni