-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shim-15.6 for circle linux #271
Comments
Sent mails for contact verification |
Your README.md and patch list still talk about shim 15.4. I'm stopping right here... |
Thanks, I have fixed my README.md and create a new tag of repo. |
Hi , if there something need to fix , please contact us. Thanks your effort. |
I have received the contact verification e-mail. The message is as follow. |
I am not a reviewer or a member of the board, however I did look at the submission and have a couple of notes:
|
@James6xie did you receive the identification emails ok? |
Yes this, i checked my email, as below: resurrecting deceasing Guy starker coatings freeloaders spewing reliefs Islamism Calvinistic -- |
contact verification done |
Thanks a lot . |
Thank you Nagy , my brother. Yes, I think Circle Linux Project should provide an real organization information, If it is difficult to join or apply for the opensource foundation, in a short time. @rouzer-zhou Yes,this indeed the 1st submission. |
I have fixed this problem, but the label is still bug, please tell me what I need to do next. |
As far as I can tell, the problems Sherif indicated still exists. Moreover, as you're a RHEL rebuild aiming for "bug for bug compatibility", I would like to discuss whether you need to get shim signed at all. If you can reproduce the unsigned RHEL builds, I think you would be better off shipping RHEL's shim+grub2+kernel, and would like to know what can be done here to enable that (I've written some tooling that may help with this). |
I have added the description of the organization information and website, please review it again. |
please review again, if there is any problem, please tell me. |
Please note #307 |
Picking up on this, sorry for the delay :-( I can't reproduce your builds here:
We're also way past the deadline for signing shims without NX now I'm afraid - see #307 . This isn't your fault, but you'll need to move forward to a newer shim version at this point. I'd recommend 15.7 or 15.8 if that comes out soon. |
It's been a few weeks, closing... |
Confirm the following are included in your repo, checking each box:
What is the link to your tag in a repo cloned from rhboot/shim-review?
https://github.com/circle-linux/shim-review/releases/tag/circlelinux-8-shim-x86_64-20221201
What is the SHA256 hash of your final SHIM binary?
9e5df2ca5289b1f297cdfa3f24d81e7e2b9e8c6ecff76585fd6a209013ef5030 shimia32.efi
612b3a6a76e6bd44ab896eb47124c3a3df6e5ebfb9310c489ffbd1a6ce62dcd3 shimx64.efi
The text was updated successfully, but these errors were encountered: