Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code / clean-up #79

Open
9 tasks
dellamonica opened this issue Oct 8, 2021 · 0 comments
Open
9 tasks

Remove unused code / clean-up #79

dellamonica opened this issue Oct 8, 2021 · 0 comments

Comments

@dellamonica
Copy link
Contributor

dellamonica commented Oct 8, 2021

Track work on cleaning up our code base.

@JohnMulligan, @yl5682 I think this should be a group effort to identify everything that should be removed from the code base.

Triage

Items here should be checked to ensure that they are really no longer needed/used.

  • voyage/management/commands/listsourcefixes.py - no idea what this is supposed to do.

To-be-removed

Items here are targeted for removal.

  • AfricanName related
    • Models
    • Solr search index
    • Views
    • Urls
    • Html links?
  • voyage/management/commands/import_AfricanNames.py - the whole African Names part of the site will be migrated to PAST so this script is obviously deprecated.
  • voyage/management/commands/importsourcesxls.py - I have never used this and at this point I don't think bulk source import has ever been required. Moreover, the code is not safe in the sense that Sources deleted will cascade and cause other data to be deleted.

Removed

List of items that were removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant