-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mermaid.js version #475
Comments
I have tried this solution on my local installtion in Windows, and it seems to work (for now). |
Duplicate with #480 |
Before this running this function with updateMermaid(version="9.3.0") I was stuck with mermaid 0.3.0 and unable to use the mermaid Entity Relationship class of diagram (erDiagram). This solved my problem. |
I'm sorry, this needs further investigations to see what has changed in the library that breaks this functionality. |
I just tried with the newest mermaid verion. The click functionality seems to be fine for the first example in #362 and the second one does not render so clicking is not even possible. This code does not work with the new version:
You will just see:
|
@trafficonese the first example isn't mermaid, unless I have misunderstood. |
you're right, thats a |
On mermaid.live it renders if you take out all the style stuff. |
Is there anything that can be done to accelerate this? |
As I see it, the problem with the newer Mermaid versions is that detecting clicks would be broken. I have played around with the newest version to create a MWE in shiny to see if interaction works, this is what I came up with:
There are two caveats:
and of course this is not in the DiagrammeR framework. But I hope this might help @rich-iannone or someone else who has enough insider knowledge to implement this in DiagrammeR. |
This issue is in echo with issues #231, #227, #241, #294, #329, #363, #421, #470, #473 and maybe some others...
The need to update the version of mermaid.js embedded in the DiagrammeR package is pressing.
As suggested in #421, we can manually update the file
/DiagrammeR/htmlwidgets/lib/mermaid/dist/mermaid.slim.min.js
in the installation folder of the package with the last version downloaded from https://cdn.jsdelivr.net/npm/mermaid/dist/mermaid.min.js.One way to always have the latest version of DiagrammeR in the package could be to add an
updateMermaid
function in the package:There are several issues with this solution:
@rich-iannone what do you think of that?
The text was updated successfully, but these errors were encountered: