You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since this component is also used internally for one of our soon to be public production app, I am not exactly sure if we should just add the enhancement. If we are to modify this particular component, we need to talk to the PM's about it first, as well as define the behaviors we want with such changes.
However, if you are eager to make a prototype and submit it via PR, I think you can create a DialPad2 component that is based on the original and submit it as an enhanced version that we can use to use in certain apps.
What I think we'd also need is to discuss the need to have versioned components. I can anticipate that in our internally developed applications based on this lib, there will be cases where some apps requires certain features that are totally different than another. Rather than building all the features into one component and just use flags to turn them on/off, we can probably build them into different components that may (or may not) have a common base component.
JS widget:
RingCentral for Mac
From the screenshots above you can see that a Backspace button is missing from JS widget.
I noticed it the first time I used the Dial Pad.
And it is a must-have if we do have plan to support mobile.
The text was updated successfully, but these errors were encountered: