Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement alert mechanism #29

Closed
niconoe opened this issue Sep 16, 2021 · 5 comments
Closed

Implement alert mechanism #29

niconoe opened this issue Sep 16, 2021 · 5 comments
Assignees

Comments

@niconoe
Copy link
Member

niconoe commented Sep 16, 2021

Large task, to be done later based on user's feedback. First ideas in #9, collecting ideas and requirement here

  1. Bram confirmed that people will need to draw their own polygons for the geographic selection, but also that having MULIPOLYGON (= for a single alert) would be great, and also shapefile(?) upload (some users already have a shapefile with the multiple tiny zones they manage).
  2. Bram: observers contact information will be a problem: often needed for management, but some people don't want to share, and privacy/RGPD must be respected AND it's not a good fit for GBIF. How to reconcile all this?
  3. Bram: e-mail frequency should be configurable: you want higher frequency for animals than plants (+ user personal preferences).
@niconoe niconoe self-assigned this Sep 16, 2021
@damianooldoni
Copy link
Collaborator

As we discussed during the meeting, I add some proposed solutions:

  1. some shapefiles could be added to this repository as we did for the three river basins
  2. the GDPR problem is not really at GBIF level: we will provide the link to the raw observation webpage (iNaturalist, waarnemingen.be, observations.org). All details the observer want to share are there, the rest is not something solvable, I think
  3. email notification frequency should be set up at alert level, not at user level

@niconoe
Copy link
Member Author

niconoe commented Sep 21, 2021

(we also added notes for that in #9: I'll have to merge/clean those notes).

Good thing is: the general mechanism appears solid to the stakeholder's we've talked with, both internally (OSCIBIO, Bram, ...) and externally (Etienne & co).

@niconoe
Copy link
Member Author

niconoe commented Dec 1, 2021

Update: I will soon implement the first version of this major feature. We need a lot of other systems in place for it, though.

Requirements:

Feature:

  • "My alerts" page
  • Add alert page
  • Edit alert page
  • See alert details (observations)
  • E-mail notifications
  • Show "unseen observations counter" for each alert, on "My alerts" page.

@niconoe
Copy link
Member Author

niconoe commented Mar 24, 2022

Update: feature implemented, but we need good tests for the email notifications, for example:

  • That the send_alert_notifications_email command does the right thing
  • That Alert.email_should_be_sent_now follows the correct business logic
  • That Alert.send_notification_email log errors and save the timestamp
  • That the user-facing page shows the time of last email sent

@niconoe
Copy link
Member Author

niconoe commented Mar 30, 2022

Since a basic alert/notification mechanism is now in place, I suggest closing this issue and extracting the few remaining points/ideas to smaller, more actionable issues.

@niconoe niconoe closed this as completed Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants