Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zfa tests missing fmvp.d.x #456

Open
davidharrishmc opened this issue Apr 22, 2024 · 2 comments
Open

Zfa tests missing fmvp.d.x #456

davidharrishmc opened this issue Apr 22, 2024 · 2 comments

Comments

@davidharrishmc
Copy link
Contributor

PR #330 is pending to add support for Zfa. The PR is missing fmvp.d.x, a RV32_Zfa instruction.

I suggest accepting the PR and adding fmvp.d.x later. This issue is to make sure the missing instruction is not forgotten.

Accodring to the PR #330 discussion (March 6, 2024), riscv-isac need enhancement to support fmv.p.d.

#330

There is a typo in the riscv-ctg PR (riscv_ctg/data/fd.yaml): s/fmvh.d.x/fmvp.d.x
After fixing the typo the test generation fails, because riscv-isac can't handle that instruction

@allenjbaum
Copy link
Collaborator

ISAC PR#330 appears to be merged now. Can this issue be closed, or is something still needed?

@davidharrishmc
Copy link
Contributor Author

davidharrishmc commented Sep 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants