Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include nf field in instruction name #263

Closed
moscickimilosz opened this issue Jul 18, 2024 · 2 comments
Closed

Include nf field in instruction name #263

moscickimilosz opened this issue Jul 18, 2024 · 2 comments

Comments

@moscickimilosz
Copy link
Contributor

The nf field is treated as a variable arg within the rv_v instruction encoding file.

As I am interested in having all rvv instructions present in the YAML output, I was wondering whether a PR that expands this would get accepted? I believe this would align better with other extensions present in the dict e.g. Zimop and Zcmop.

I can see 3 possible solutions:

  1. Expand rv_v file to include all of the instructions
  2. Expand rv_v file to include all of the instructions, with the new instructions encoded as $pseudo_op (following what is done in rv_zimop and rv_zcmop)
  3. Edit parse.py to expand dictionary only for the YAML output - avoid altering other outputs.
@aswaterman
Copy link
Member

Whatever we end up doing here, for backwards compatibility we need to make sure that the existing definitions that end up in encoding.out.h, inst.chisel, etc. are retained.

@moscickimilosz
Copy link
Contributor Author

Whatever we end up doing here, for backwards compatibility we need to make sure that the existing definitions that end up in encoding.out.h, inst.chisel, etc. are retained.

Hi @aswaterman,
Could you please take a look at the proposed solution in this PR?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants