Updated Smmpt to address ARC feedback #121
Open
+492
−461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ravi Sahita <[email protected]>
ved-rivos
reviewed
Feb 6, 2025
Signed-off-by: Ved Shanbhogue <[email protected]>
This reverts commit f2db9d6.
Signed-off-by: Ravi Sahita <[email protected]>
|
smmtt-spec-PR-121-2-18-2025.pdf PDF to make reviewing easier. |
ved-rivos
approved these changes
Feb 17, 2025
Signed-off-by: Ravi Sahita <[email protected]>
ved-rivos
reviewed
Feb 19, 2025
Co-authored-by: Ved Shanbhogue <[email protected]> Signed-off-by: Ravi Sahita <[email protected]>
rsahita
commented
Feb 19, 2025
Signed-off-by: Ravi Sahita <[email protected]>
There was a problem hiding this comment.
I've provided my comments on Smmptnlnapot as a pull request (#126) because I mostly rewrote the section to make it (hopefully) easier to understand.
Signed-off-by: Samuel Holland <[email protected]>
rsahita
commented
Feb 24, 2025
rsahita
commented
Feb 24, 2025
Co-authored-by: Samuel Holland <[email protected]> Signed-off-by: Ravi Sahita <[email protected]>
rsahita
commented
Feb 24, 2025
rsahita
commented
Feb 24, 2025
rsahita
commented
Feb 24, 2025
rsahita
commented
Feb 24, 2025
Signed-off-by: Ravi Sahita <[email protected]>
Signed-off-by: Ravi Sahita <[email protected]>
rsahita
commented
Feb 26, 2025
rsahita
commented
Feb 26, 2025
Co-authored-by: Samuel Holland <[email protected]> Signed-off-by: Ravi Sahita <[email protected]>
rsahita
commented
Feb 26, 2025
Signed-off-by: Ravi Sahita <[email protected]>
rsahita
commented
Feb 26, 2025
Signed-off-by: Ravi Sahita <[email protected]>
SiFiveHolland
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support upto 64 bit address (52 bit ppn at each non-leaf)
Non-leaf entry has ppn, valid bit + napot bit
Leaf entry updated with RWX perms
Napot for non-leaf allows entries to be coalesced (larger next level)
Napot in leaf supports super page sizes
Common non-leaf and leaf format
See this presentation for an overview (the format has been updated from the presentation so refer to it only as an overview - read specifics in the PR please): https://docs.google.com/presentation/d/1Zzd5Jm6HeITo4vjJzoAnOp9wGHsOVPEI8FL2BJc8YsE/edit#slide=id.g32322424817_0_7