SpiderMonkey build issues

[jailbird777]

Attempting to build 0.18.0 with SpiderMoney 128, which is the required version according to the changelog, errors with:

FAILED: src/elinks.p/js_spidermonkey_fragment.cpp.o
c++ -Isrc/elinks.p -Isrc -I../src -I. -I.. -I/usr/local/include -I/usr/local/include/nspr -I/usr/local/lib/perl5/5.40/mach/CORE -I/usr/local/include/js-128 -fdiagnostics-color=never -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu++17 -O2 -pipe -O3 -march=native -mtune=native -fzero-call-used-regs=used -fstack-protector-all -Qunused-arguments -isystem /usr/local/include -fno-strict-aliasing -O3 -march=native -mtune=native -DHARDENEDBSD -fzero-call-used-regs=used -isystem /usr/local/include -DLIBICONV_PLUG -isystem /usr/local/include -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -fstack-protector-strong -isystem /usr/local/include/mozjs-128 -isystem /usr/local/include -DHAVE_CONFIG_H -fno-strict-aliasing -Wno-address -Wno-array-bounds -fpermissive -Wno-sign-compare -MD -MQ src/elinks.p/js_spidermonkey_fragment.cpp.o -MF src/elinks.p/js_spidermonkey_fragment.cpp.o.d -o src/elinks.p/js_spidermonkey_fragment.cpp.o -c ../src/js/spidermonkey/fragment.cpp
In file included from ../src/js/spidermonkey/fragment.cpp:15:
In file included from ../src/js/spidermonkey/util.h:4:
In file included from ../src/js/spidermonkey-shared.h:4:
In file included from /usr/local/include/mozjs-128/jsapi.h:30:
In file included from /usr/local/include/mozjs-128/js/CallAndConstruct.h:15:
/usr/local/include/mozjs-128/js/RootingAPI.h:1182:9: error: cannot initialize a member subobject of type 'JSObject *' with an lvalue of type 'void *'
1182 | : ptr(std::forward(initial)) {
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~
../src/js/spidermonkey/fragment.cpp:2293:19: note: in instantiation of function template specialization 'JS::Rooted<JSObject *>::Rooted<JSContext *, void *&>' requested here
2293 | JS::RootedObject r_doc(ctx, interpreter->document_obj);
| ^
1 error generated.

I tried to fix it myself, but I'm a C guy, not a C++ guy, so I have no clue how instantiations work.

[rkd77]

Oh, sorry, I did not build it under BSD. You can try cast interpreter->document_obj to (JSObject *).
Here it would be:
JS::RootedObject r_doc(ctx, (JSObject *)interpreter->document_obj);
If such places is more, you can change void * to JSObject * at the begining of the ecmascript.h in the struct ecmascript_interpreter.

[dmarquess2]

Bingo! That did the trick, thanks!