Ctrl+Shift+F does not work correctly

[friederbluemle]

When applying the auto-formatter, this plugin does not correctly format Gherkin feature files.

Before:

After:

Note the incorrect indentation, mix of tabs and spaces, and appended spaces.

Is there a way to customize the formatter or does this require a fix in the plugin iteself?

[rlogiacco]

Quick answer: it requires a plugin fix.

Long Answer
This issue is a consequence of the syntax definition. I've tried everything I was aware of with regards of defining the correct parser within Xtext, apparently I wasn't able to find a way to do it properly.

A solution for this and many other issues would be to replace the generated Xtext parser with the official gherkin parser which is used by Cucumber-JVM. To achieve such result though I need some help as there's a lot of information I'm missing.

Someone with good knowledge of Antlr or Xtext would really be helpful on this: do you know anybody willing to contribute?

[github-actions]

This issue has not been updated for a while: marking it as stale.

[friederbluemle]

Thanks @github-actions 😂

[drkstr101]

This is fixable using the new formatting2 API in latest Xtext.

I am flagging this issue for review in next

[github-actions]

This issue has not been updated for a while: marking it as stale.

[friederbluemle]

Can we please keep this open until the pending work/feedback is resolved?

[drkstr101]

@rlogiacco I agree, this is still an unresolved issue. It has improved somewhat in current master (unreleased as of yet), but won't be fully supported until the 1.0 milestone release.

The current behavior in master is to simply preserve the existing Narrative formatting. Later we can add rules for things like whitespace cleanup or auto-indent.

[drkstr101]

@rlogiacco This can be closed with #86