Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MultiBinary and MultiDiscrete #3

Open
jonashen opened this issue Aug 15, 2018 · 6 comments
Open

Add support for MultiBinary and MultiDiscrete #3

jonashen opened this issue Aug 15, 2018 · 6 comments

Comments

@jonashen
Copy link
Member

No description provided.

@ryanjulian
Copy link
Member

I can't find a single gym.Env which uses these, so it's not a high priority. I think we should include them eventually for the same of completeness.

@jonashen
Copy link
Member Author

It's probably a WIP for them.

@ryanjulian
Copy link
Member

@krzentner this is an akro bug

@ryanjulian ryanjulian transferred this issue from rlworkgroup/garage Dec 4, 2018
@sud0nick
Copy link
Contributor

@jonashen @ryanjulian These are still not used in any gym.Env but they are used in gym/utils.py and support exists in dict.py. Is this something that still needs to be added to akro or has it dropped off the radar?

@ryanjulian
Copy link
Member

ryanjulian commented May 15, 2019

Sorry for the slow response.

I think this is still desirable for coverage reasons, even though it's not used anywhere in gym. I don't think it's very high-priority.

Our ambition for this library is "gym.Spaces, but with all the missing features." So it makes sense we should provide our features for any types which gym provides (and it's pretty easy anyway).

@chen-tianjian
Copy link

I wish to follow up with this. We wish to use akro and garage for a custom environment with MultiDiscrete actions, could you please suggest some alternative ways if MultiDiscrete is not supported?
(We tried akro.Tuple but it seems like the algorithm implementations (e.g. PPO) in garage does not support this type?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants